binexport: remove outdated TODOs

mandiant · Aug 16, 2024 · bfbd4ad · bfbd4ad
1 parent afa0215
commit bfbd4ad
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 15 deletions.
diff --git a/capa/features/extractors/binexport2/function.py b/capa/features/extractors/binexport2/function.py
@@ -42,7 +42,6 @@ def extract_function_loop(fh: FunctionHandle) -> Iterator[Tuple[Feature, Address
 
     edges: List[Tuple[int, int]] = []
     for edge in flow_graph.edge:
-        # TODO (meh): use Edge.is_back_edge pending https://github.com/mandiant/capa/issues/2101
         edges.append((edge.source_basic_block_index, edge.target_basic_block_index))
 
     if loops.has_loop(edges):

diff --git a/capa/features/extractors/binexport2/insn.py b/capa/features/extractors/binexport2/insn.py
@@ -65,20 +65,6 @@ def extract_insn_api_features(fh: FunctionHandle, _bbh: BBHandle, ih: InsnHandle
         for name in capa.features.extractors.helpers.generate_symbols("", api_name):
             yield API(name), ih.address
 
-    """
-        # TODO: re-enable pending https://github.com/google/binexport/issues/126#issuecomment-2074402906
-        function_name = vertex.mangled_name
-        if vertex.HasField("library_index"):
-            # TODO: this seems to be incorrect for Ghidra extractor
-            library = be2.library[vertex.library_index]
-            library_name = library.name
-
-            for name in capa.features.extractors.helpers.generate_symbols(library_name, function_name):
-                yield API(name), ih.address
-        else:
-            yield API(function_name), ih.address
-    """
-
 
 def extract_insn_number_features(
     fh: FunctionHandle, bbh: BBHandle, ih: InsnHandle