Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve existing persistence rules #953

Merged
merged 8 commits into from
Dec 9, 2024

Conversation

jorik-utwente
Copy link
Contributor

Improve existing persistence rules by limiting their scope, and adding some more details.

This PR requires #952 to be merged.

Copy link
Collaborator

@mr-tz mr-tz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice updates! Please see my comments inline.

@williballenthin williballenthin self-requested a review December 5, 2024 11:58
@williballenthin williballenthin mentioned this pull request Dec 6, 2024
16 tasks
Copy link
Collaborator

@mr-tz mr-tz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you very much!

@mr-tz mr-tz merged commit ce5e041 into mandiant:master Dec 9, 2024
3 checks passed
@jorik-utwente
Copy link
Contributor Author

@mr-tz Note that some of the changes here introduce new false negatives for other sandbox backends, as discussed here: #954 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants