Upgrade rules for static and dynamic scopes #837
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mr-tz
commented
Oct 13, 2023
...-analysis/anti-av/block-operations-on-executable-memory-pages-using-arbitrary-code-guard.yml
Show resolved
Hide resolved
| scope: basic block | ||
| scopes: | ||
| static: basic block | ||
| dynamic: call # TODO check if scope thread instead |
There was a problem hiding this comment.
Suggested change
| dynamic: call # TODO check if scope thread instead | |
| dynamic: thread |
| scope: basic block | ||
| scopes: | ||
| static: basic block | ||
| dynamic: call # TODO check if scope thread instead |
There was a problem hiding this comment.
Suggested change
| dynamic: call # TODO check if scope thread instead | |
| dynamic: call |
| scope: function | ||
| scopes: | ||
| static: function | ||
| dynamic: unspecified # TODO upgrade manually, contains unsupported feature property for dynamic scope |
There was a problem hiding this comment.
Suggested change
| dynamic: unspecified # TODO upgrade manually, contains unsupported feature property for dynamic scope | |
| dynamic: call |
| scope: function | ||
| scopes: | ||
| static: function | ||
| dynamic: unspecified # TODO upgrade manually, contains unsupported feature mnemonic for dynamic scope |
There was a problem hiding this comment.
Suggested change
| dynamic: unspecified # TODO upgrade manually, contains unsupported feature mnemonic for dynamic scope | |
| dynamic: unsupported |
| scope: basic block | ||
| scopes: | ||
| static: basic block | ||
| dynamic: call # TODO check if scope thread instead |
There was a problem hiding this comment.
Suggested change
| dynamic: call # TODO check if scope thread instead | |
| dynamic: thread |
| scope: basic block | ||
| scopes: | ||
| static: basic block | ||
| dynamic: unspecified # TODO upgrade manually, contains match |
There was a problem hiding this comment.
Suggested change
| dynamic: unspecified # TODO upgrade manually, contains match | |
| dynamic: unsupported |
| scope: function | ||
| scopes: | ||
| static: function | ||
| dynamic: unspecified # TODO upgrade manually, contains Subscope |
There was a problem hiding this comment.
Suggested change
| dynamic: unspecified # TODO upgrade manually, contains Subscope | |
| dynamic: unsupported |
| scope: function | ||
| scopes: | ||
| static: function | ||
| dynamic: unspecified # TODO upgrade manually, contains Subscope |
There was a problem hiding this comment.
this one is a bit more tricky
| scope: function | ||
| scopes: | ||
| static: function | ||
| dynamic: unspecified # TODO upgrade manually, contains match |
There was a problem hiding this comment.
Suggested change
| dynamic: unspecified # TODO upgrade manually, contains match | |
| dynamic: thread |
mr-tz
force-pushed
the
dynamic-rules-mr
branch
from
4b5fa3b to
364413c
Compare
mr-tz
commented
Oct 16, 2023
| scope: basic block | ||
| scopes: | ||
| static: basic block | ||
| dynamic: call # TODO check if scope thread instead |
There was a problem hiding this comment.
Suggested change
| dynamic: call # TODO check if scope thread instead | |
| dynamic: call |
| scope: function | ||
| scopes: | ||
| static: function | ||
| dynamic: unspecified # TODO upgrade manually, contains Subscope |
There was a problem hiding this comment.
Suggested change
| dynamic: unspecified # TODO upgrade manually, contains Subscope | |
| dynamic: unsupported |
There was a problem hiding this comment.
should we add comments on why this is for each rule?
| scope: function | ||
| scopes: | ||
| static: function | ||
| dynamic: unspecified # TODO upgrade manually, contains Subscope |
There was a problem hiding this comment.
Suggested change
| dynamic: unspecified # TODO upgrade manually, contains Subscope | |
| dynamic: unsupported # requires low-level mnemonic features |
| scope: basic block | ||
| scopes: | ||
| static: basic block | ||
| dynamic: unspecified # TODO upgrade manually, contains unsupported feature mnemonic for dynamic scope |
There was a problem hiding this comment.
Suggested change
| dynamic: unspecified # TODO upgrade manually, contains unsupported feature mnemonic for dynamic scope | |
| dynamic: unsupported # requires low-level mnemonic features |
| scope: basic block | ||
| scopes: | ||
| static: basic block | ||
| dynamic: call # TODO check if scope thread instead |
There was a problem hiding this comment.
Suggested change
| dynamic: call # TODO check if scope thread instead | |
| dynamic: call |
| scope: function | ||
| scopes: | ||
| static: function | ||
| dynamic: unspecified # TODO upgrade manually, contains match |
There was a problem hiding this comment.
Suggested change
| dynamic: unspecified # TODO upgrade manually, contains match | |
| dynamic: unsupported # requires `contain loop` match, but could be rewritten for dynamic without this |
| scope: basic block | ||
| scopes: | ||
| static: basic block | ||
| dynamic: call # TODO check if scope thread instead |
There was a problem hiding this comment.
Suggested change
| dynamic: call # TODO check if scope thread instead | |
| dynamic: call |
| scope: function | ||
| scopes: | ||
| static: function | ||
| dynamic: unspecified # TODO upgrade manually, contains unsupported feature mnemonic for dynamic scope |
There was a problem hiding this comment.
Suggested change
| dynamic: unspecified # TODO upgrade manually, contains unsupported feature mnemonic for dynamic scope | |
| dynamic: unsupported # requires low-level mnemonic features |
| scope: function | ||
| scopes: | ||
| static: function | ||
| dynamic: unspecified # TODO upgrade manually, contains Subscope |
There was a problem hiding this comment.
Suggested change
| dynamic: unspecified # TODO upgrade manually, contains Subscope | |
| dynamic: unsupported # requires low-level mnemonic features |
mr-tz
commented
Oct 18, 2023
| scope: file | ||
| scopes: | ||
| static: file | ||
| dynamic: unspecified # TODO upgrade manually, contains match |
There was a problem hiding this comment.
Suggested change
| dynamic: unspecified # TODO upgrade manually, contains match | |
| dynamic: unsupported # match requires low-level mnemonic features |
| scope: basic block | ||
| scopes: | ||
| static: basic block | ||
| dynamic: call # TODO check if scope thread instead |
There was a problem hiding this comment.
Suggested change
| dynamic: call # TODO check if scope thread instead | |
| dynamic: thread |
| scope: function | ||
| scopes: | ||
| static: function | ||
| dynamic: unspecified # TODO upgrade manually, contains match |
There was a problem hiding this comment.
Suggested change
| dynamic: unspecified # TODO upgrade manually, contains match | |
| dynamic: thread |
| scope: function | ||
| scopes: | ||
| static: function | ||
| dynamic: unspecified # TODO upgrade manually, contains Subscope |
There was a problem hiding this comment.
Suggested change
| dynamic: unspecified # TODO upgrade manually, contains Subscope | |
| dynamic: unsupported # requires low-level features |
| scope: function | ||
| scopes: | ||
| static: function | ||
| dynamic: unspecified # TODO upgrade manually, contains match |
There was a problem hiding this comment.
Suggested change
| dynamic: unspecified # TODO upgrade manually, contains match | |
| dynamic: thread |
| scope: file | ||
| scopes: | ||
| static: file | ||
| dynamic: unspecified # TODO upgrade manually, contains unsupported feature class for dynamic scope |
There was a problem hiding this comment.
Suggested change
| dynamic: unspecified # TODO upgrade manually, contains unsupported feature class for dynamic scope | |
| dynamic: unsupported # requires class feature |
| scope: function | ||
| scopes: | ||
| static: function | ||
| dynamic: unspecified # TODO upgrade manually, contains unsupported feature mnemonic for dynamic scope |
There was a problem hiding this comment.
Suggested change
| dynamic: unspecified # TODO upgrade manually, contains unsupported feature mnemonic for dynamic scope | |
| dynamic: unsupported # requires low-level mnemonic features |
| scope: function | ||
| scopes: | ||
| static: function | ||
| dynamic: unspecified # TODO upgrade manually, contains Subscope |
There was a problem hiding this comment.
Suggested change
| dynamic: unspecified # TODO upgrade manually, contains Subscope | |
| dynamic: unsupported # requires low-level mnemonic features |
| scope: function | ||
| scopes: | ||
| static: function | ||
| dynamic: unspecified # TODO upgrade manually, contains match |
There was a problem hiding this comment.
Suggested change
| dynamic: unspecified # TODO upgrade manually, contains match | |
| dynamic: thread |
| scope: basic block | ||
| scopes: | ||
| static: basic block | ||
| dynamic: call # TODO check if scope thread instead |
There was a problem hiding this comment.
Suggested change
| dynamic: call # TODO check if scope thread instead | |
| dynamic: thread |
18 tasks
mr-tz
commented
Oct 20, 2023
| scope: function | ||
| scopes: | ||
| static: function | ||
| dynamic: thread |
There was a problem hiding this comment.
Suggested change
| dynamic: thread | |
| dynamic: call |
| scope: file | ||
| scopes: | ||
| static: file | ||
| dynamic: unspecified # TODO upgrade manually, contains match |
There was a problem hiding this comment.
Suggested change
| dynamic: unspecified # TODO upgrade manually, contains match | |
| dynamic: file |
| scope: function | ||
| scopes: | ||
| static: function | ||
| dynamic: unspecified # TODO upgrade manually, contains Subscope |
There was a problem hiding this comment.
Suggested change
| dynamic: unspecified # TODO upgrade manually, contains Subscope | |
| dynamic: thread |
There was a problem hiding this comment.
- TODO: double check operand numbers work
| scope: function | ||
| scopes: | ||
| static: function | ||
| dynamic: unspecified # TODO upgrade manually, contains Subscope |
There was a problem hiding this comment.
Suggested change
| dynamic: unspecified # TODO upgrade manually, contains Subscope | |
| dynamic: thread |
| scope: file | ||
| scopes: | ||
| static: file | ||
| dynamic: unspecified # TODO upgrade manually, contains match |
There was a problem hiding this comment.
Suggested change
| dynamic: unspecified # TODO upgrade manually, contains match | |
| dynamic: file |
| scope: function | ||
| scopes: | ||
| static: function | ||
| dynamic: unspecified # TODO upgrade manually, contains unsupported feature mnemonic for dynamic scope |
There was a problem hiding this comment.
Suggested change
| dynamic: unspecified # TODO upgrade manually, contains unsupported feature mnemonic for dynamic scope | |
| dynamic: unsupported # contains unsupported feature mnemonic |
| scope: function | ||
| scopes: | ||
| static: function | ||
| dynamic: thread |
There was a problem hiding this comment.
Suggested change
| dynamic: thread | |
| dynamic: call |
| scope: basic block | ||
| scopes: | ||
| static: basic block | ||
| dynamic: call # TODO check if scope thread instead |
There was a problem hiding this comment.
Suggested change
| dynamic: call # TODO check if scope thread instead | |
| dynamic: call |
| scope: function | ||
| scopes: | ||
| static: function | ||
| dynamic: unspecified # TODO upgrade manually, contains match |
There was a problem hiding this comment.
Suggested change
| dynamic: unspecified # TODO upgrade manually, contains match | |
| dynamic: thread |
| scope: function | ||
| scopes: | ||
| static: function | ||
| dynamic: unspecified # TODO upgrade manually, contains match |
There was a problem hiding this comment.
Suggested change
| dynamic: unspecified # TODO upgrade manually, contains match | |
| dynamic: thread |
mr-tz
commented
Oct 20, 2023
| scope: file | ||
| scopes: | ||
| static: file | ||
| dynamic: unspecified # TODO upgrade manually, contains match |
There was a problem hiding this comment.
Suggested change
| dynamic: unspecified # TODO upgrade manually, contains match | |
| dynamic: file |
| scope: basic block | ||
| scopes: | ||
| static: basic block | ||
| dynamic: call # TODO check if scope thread instead |
There was a problem hiding this comment.
Suggested change
| dynamic: call # TODO check if scope thread instead | |
| dynamic: call |
| scope: function | ||
| scopes: | ||
| static: function | ||
| dynamic: unspecified # TODO upgrade manually, contains Subscope |
There was a problem hiding this comment.
Suggested change
| dynamic: unspecified # TODO upgrade manually, contains Subscope | |
| dynamic: unsupported # requires low-level mnemonic features |
| scope: function | ||
| scopes: | ||
| static: function | ||
| dynamic: unspecified # TODO upgrade manually, contains Subscope |
There was a problem hiding this comment.
Suggested change
| dynamic: unspecified # TODO upgrade manually, contains Subscope | |
| dynamic: unsupported # requires low-level mnemonic features |
There was a problem hiding this comment.
although just the RtlComputeCrc32 api would work here
| scope: function | ||
| scopes: | ||
| static: function | ||
| dynamic: unspecified # TODO upgrade manually, contains match |
There was a problem hiding this comment.
Suggested change
| dynamic: unspecified # TODO upgrade manually, contains match | |
| dynamic: unsupported # matches rely on low-level features |
| scope: function | ||
| scopes: | ||
| static: function | ||
| dynamic: unspecified # TODO upgrade manually, contains unsupported feature bytes for dynamic scope |
There was a problem hiding this comment.
Suggested change
| dynamic: unspecified # TODO upgrade manually, contains unsupported feature bytes for dynamic scope | |
| dynamic: unsupported # contains unsupported feature bytes |
| scope: function | ||
| scopes: | ||
| static: function | ||
| dynamic: unspecified # TODO upgrade manually, contains match |
There was a problem hiding this comment.
Suggested change
| dynamic: unspecified # TODO upgrade manually, contains match | |
| dynamic: unsupported # requires low-level mnemonic features |
| scope: function | ||
| scopes: | ||
| static: function | ||
| dynamic: unspecified # TODO upgrade manually, contains Subscope |
There was a problem hiding this comment.
Suggested change
| dynamic: unspecified # TODO upgrade manually, contains Subscope | |
| dynamic: unsupported # requires low-level mnemonic features |
| scope: function | ||
| scopes: | ||
| static: function | ||
| dynamic: unspecified # TODO upgrade manually, contains Subscope |
There was a problem hiding this comment.
Suggested change
| dynamic: unspecified # TODO upgrade manually, contains Subscope | |
| dynamic: unsupported # requires low-level mnemonic features |
mr-tz
commented
Oct 24, 2023
| scope: function | ||
| scopes: | ||
| static: function | ||
| dynamic: unspecified # TODO upgrade manually, contains match |
There was a problem hiding this comment.
Suggested change
| dynamic: unspecified # TODO upgrade manually, contains match | |
| dynamic: unsupported # requires low-level mnemonic features |
| scope: function | ||
| scopes: | ||
| static: function | ||
| dynamic: unspecified # TODO upgrade manually, contains unsupported feature bytes for dynamic scope |
There was a problem hiding this comment.
Suggested change
| dynamic: unspecified # TODO upgrade manually, contains unsupported feature bytes for dynamic scope | |
| dynamic: unsupported # contains unsupported feature bytes |
| scope: function | ||
| scopes: | ||
| static: function | ||
| dynamic: unspecified # TODO upgrade manually, contains unsupported feature mnemonic for dynamic scope |
There was a problem hiding this comment.
Suggested change
| dynamic: unspecified # TODO upgrade manually, contains unsupported feature mnemonic for dynamic scope | |
| dynamic: unsupported # requires low-level mnemonic features |
| scope: basic block | ||
| scopes: | ||
| static: basic block | ||
| dynamic: call # TODO check if scope thread instead |
There was a problem hiding this comment.
Suggested change
| dynamic: call # TODO check if scope thread instead | |
| dynamic: call |
| scope: basic block | ||
| scopes: | ||
| static: basic block | ||
| dynamic: call # TODO check if scope thread instead |
There was a problem hiding this comment.
Suggested change
| dynamic: call # TODO check if scope thread instead | |
| dynamic: call |
| scope: function | ||
| scopes: | ||
| static: function | ||
| dynamic: thread |
There was a problem hiding this comment.
Suggested change
| dynamic: thread | |
| dynamic: call |
| scope: function | ||
| scopes: | ||
| static: function | ||
| dynamic: thread |
There was a problem hiding this comment.
Suggested change
| dynamic: thread | |
| dynamic: call |
| scope: basic block | ||
| scopes: | ||
| static: basic block | ||
| dynamic: call # TODO check if scope thread instead |
There was a problem hiding this comment.
Suggested change
| dynamic: call # TODO check if scope thread instead | |
| dynamic: call |
| scope: function | ||
| scopes: | ||
| static: function | ||
| dynamic: thread |
There was a problem hiding this comment.
Suggested change
| dynamic: thread | |
| dynamic: call |
| scope: function | ||
| scopes: | ||
| static: function | ||
| dynamic: thread |
There was a problem hiding this comment.
Suggested change
| dynamic: thread | |
| dynamic: call |
mr-tz
commented
Oct 24, 2023
| scope: function | ||
| scopes: | ||
| static: function | ||
| dynamic: thread |
There was a problem hiding this comment.
Suggested change
| dynamic: thread | |
| dynamic: call |
| scope: function | ||
| scopes: | ||
| static: function | ||
| dynamic: thread |
There was a problem hiding this comment.
Suggested change
| dynamic: thread | |
| dynamic: call |
| scope: function | ||
| scopes: | ||
| static: function | ||
| dynamic: thread |
There was a problem hiding this comment.
Suggested change
| dynamic: thread | |
| dynamic: call |
| scope: function | ||
| scopes: | ||
| static: function | ||
| dynamic: thread |
There was a problem hiding this comment.
Suggested change
| dynamic: thread | |
| dynamic: call |
| scope: function | ||
| scopes: | ||
| static: function | ||
| dynamic: thread |
There was a problem hiding this comment.
Suggested change
| dynamic: thread | |
| dynamic: call |
| scope: function | ||
| scopes: | ||
| static: function | ||
| dynamic: thread |
There was a problem hiding this comment.
Suggested change
| dynamic: thread | |
| dynamic: unsupported # requires .NET features |
| scope: function | ||
| scopes: | ||
| static: function | ||
| dynamic: thread |
There was a problem hiding this comment.
Suggested change
| dynamic: thread | |
| dynamic: call |
| scope: basic block | ||
| scopes: | ||
| static: basic block | ||
| dynamic: call # TODO check if scope thread instead |
There was a problem hiding this comment.
Suggested change
| dynamic: call # TODO check if scope thread instead | |
| dynamic: unsupported # requires .NET features |
| scope: function | ||
| scopes: | ||
| static: function | ||
| dynamic: thread |
There was a problem hiding this comment.
Suggested change
| dynamic: thread | |
| dynamic: unsupported # requires .NET features |
| scope: function | ||
| scopes: | ||
| static: function | ||
| dynamic: thread |
There was a problem hiding this comment.
Suggested change
| dynamic: thread | |
| dynamic: unsupported # requires .NET features |
|
seems like all the comments/suggestions broke the web UI 😑 working on a new script to update rules based on what I learned doing it manually |
|
superseded by #839 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #816 based initially on a script.
Plan to fix most rules manually in here moving forward after inline discussions below.