Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create add-value-to-global-atom-table.yml #831

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Create add-value-to-global-atom-table.yml #831

merged 2 commits into from
Oct 10, 2023

Conversation

mr-tz
Copy link
Collaborator

@mr-tz mr-tz commented Sep 23, 2023

part of #88

mike-hunhoff
mike-hunhoff requested changes Oct 9, 2023
View reviewed changes
Copy link
Collaborator

@mike-hunhoff mike-hunhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @mr-tz - I've suggested two additional APIs that I believe we should match here as well. Let me know what you think!

nursery/add-value-to-global-atom-table.yml Show resolved Hide resolved
@mr-tz
Copy link
Collaborator Author

mr-tz commented Oct 10, 2023

Great, thanks!

@mr-tz mr-tz requested a review from mike-hunhoff October 10, 2023 09:01
@mr-tz mr-tz merged commit 773c75c into master Oct 10, 2023
2 of 3 checks passed
@mr-tz mr-tz deleted the mr-tz-patch-2 branch October 10, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mike-hunhoff mike-hunhoff Awaiting requested review from mike-hunhoff

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mr-tz @mike-hunhoff