feat(docker): add ARM support #132
Conversation
This will take a little bit longer to build, but works on raspberry pi
|
tested and running on a raspberry pi 4 - you can use |
|
I think this looks really good. Just had a couple comments. |
|
@kalioz did you see my comments? |
|
As a matter of facts no :D Where did you put them ? |
| - name: Set up QEMU | ||
| uses: docker/setup-qemu-action@v1 | ||
| - name: Set up Docker Buildx | ||
| uses: docker/setup-buildx-action@v1 |
There was a problem hiding this comment.
I see there is a v2 available for both of these actions. Should we use those?
| RUN apk --update-cache add --virtual build-dependencies gcc libc-dev make \ | ||
|
|
||
| ENV CARGO_NET_GIT_FETCH_WITH_CLI=true | ||
| RUN apk --update-cache --no-cache add --virtual build-dependencies build-base gcc libc-dev make rust cargo git alpine-sdk \ |
There was a problem hiding this comment.
what is rust and cargo needed for?
There was a problem hiding this comment.
cargo+rust was needed for one of pip's dependencies; the change to uvicorn instead of uvicorn[standard] may have fixed this, i'll check if i can remove them now
|
@kalioz yeah my mistake, I had left inline comments but didn't submit the review. Can you see them now? |
|
Yeah ! I'll work on them tonight to see if I can make the changes :) |
|
Hey, finally got around to making a change to address this. #166 I ended up building on this and now check platform_machine in the requirements.txt so we can still use cython on x86. Thanks for the work investigating the uvicorn dep arm compatibility. |
This will take a little bit longer to build, but works on raspberry pi
solves #69 #23