Skip to content

Commit

Permalink
Add a TODO for using GetLatestRevision for UpdateSecret service method;
Browse files Browse the repository at this point in the history
  • Loading branch information
ycliuhw committed May 9, 2024
1 parent 5603cb7 commit 7d2b86f
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions domain/secret/service/service.go
Original file line number Diff line number Diff line change
Expand Up @@ -308,6 +308,7 @@ func (s *SecretService) UpdateUserSecret(ctx context.Context, uri *secrets.URI,
// loadBackendInfo will error is there's no active backend.
backend := s.backends[s.activeBackendID]

// TODO: use a bespoke "GetLatestRevision(ctx, uri) method instead of GetSecret().
md, err := s.GetSecret(ctx, uri)
if err != nil {
// Check if the uri exists or not.
Expand Down

0 comments on commit 7d2b86f

Please sign in to comment.