Merge pull request juju#16975 from wallyworld/storage-pool-domain

juju#16975

This PR adds the domain and service packages for managing storage pools. The main use cases to support are CRUD from the CLI (including querying based on a names and types filter), as well as getting a pool by name for use in the provisioning and deploy facades.

The service needs a registry representing the valid storage provisioners for the current model - this is passed in when the service is constructed.

## QA steps

just unit tests at this stage

## Links

**Jira card:** JUJU-5579

domain/servicefactory/model.go

@@ -20,8 +20,11 @@ import (
 	networkstate "github.com/juju/juju/domain/network/state"
 	objectstoreservice "github.com/juju/juju/domain/objectstore/service"
 	objectstorestate "github.com/juju/juju/domain/objectstore/state"
+	storageservice "github.com/juju/juju/domain/storage/service"
+	storagestate "github.com/juju/juju/domain/storage/state"
 	unitservice "github.com/juju/juju/domain/unit/service"
 	unitstate "github.com/juju/juju/domain/unit/state"
+	"github.com/juju/juju/internal/storage"
 )
 
 // ModelFactory provides access to the services required by the apiserver.
@@ -114,3 +117,12 @@ func (s *ModelFactory) Annotation() *annotationService.Service {
 		annotationState.NewState(changestream.NewTxnRunnerFactory(s.modelDB)),
 	)
 }
+
+// Storage returns the model's storage service.
+func (s *ModelFactory) Storage(registry storage.ProviderRegistry) *storageservice.Service {
+	return storageservice.NewService(
+		storagestate.NewState(changestream.NewTxnRunnerFactory(s.modelDB)),
+		s.logger.Child("storage"),
+		registry,
+	)
+}

domain/servicefactory/testing/service.go

@@ -21,10 +21,12 @@ import (
 	modelmanagerservice "github.com/juju/juju/domain/modelmanager/service"
 	networkservice "github.com/juju/juju/domain/network/service"
 	objectstoreservice "github.com/juju/juju/domain/objectstore/service"
+	storageservice "github.com/juju/juju/domain/storage/service"
 	unitservice "github.com/juju/juju/domain/unit/service"
 	upgradeservice "github.com/juju/juju/domain/upgrade/service"
 	userservice "github.com/juju/juju/domain/user/service"
 	"github.com/juju/juju/internal/servicefactory"
+	"github.com/juju/juju/internal/storage"
 )
 
 // TestingServiceFactory provides access to the services required by the apiserver.
@@ -133,6 +135,11 @@ func (s *TestingServiceFactory) Annotation() *annotationservice.Service {
 	return nil
 }
 
+// Storage returns the storage service.
+func (s *TestingServiceFactory) Storage(storage.ProviderRegistry) *storageservice.Service {
+	return nil
+}
+
 // FactoryForModel returns a service factory for the given model uuid.
 // This will late bind the model service factory to the actual service factory.
 func (s *TestingServiceFactory) FactoryForModel(modelUUID string) servicefactory.ServiceFactory {

domain/storage/errors/errors.go

@@ -0,0 +1,21 @@
+// Copyright 2024 Canonical Ltd.
+// Licensed under the AGPLv3, see LICENCE file for details.
+
+package errors
+
+import (
+	"github.com/juju/errors"
+)
+
+const (
+	// MissingPoolTypeError is used when a provider type is empty.
+	MissingPoolTypeError = errors.ConstError("pool provider type is empty")
+	// MissingPoolNameError is used when a name is empty.
+	MissingPoolNameError = errors.ConstError("pool name is empty")
+
+	InvalidPoolNameError = errors.ConstError("pool name is not valid")
+
+	PoolNotFoundError = errors.ConstError("storage pool is not found")
+
+	PoolAlreadyExists = errors.ConstError("storage pool already exists")
+)

domain/storage/package_test.go

@@ -0,0 +1,14 @@
+// Copyright 2024 Canonical Ltd.
+// Licensed under the AGPLv3, see LICENCE file for details.
+
+package storage
+
+import (
+	"testing"
+
+	gc "gopkg.in/check.v1"
+)
+
+func TestPackage(t *testing.T) {
+	gc.TestingT(t)
+}

domain/storage/service/package_test.go

@@ -0,0 +1,15 @@
+// Copyright 2024 Canonical Ltd.
+// Licensed under the AGPLv3, see LICENCE file for details.
+
+package service
+
+import (
+	"testing"
+
+	gc "gopkg.in/check.v1"
+)
+
+//go:generate go run go.uber.org/mock/mockgen -package service -destination state_mock_test.go github.com/juju/juju/domain/storage/service State
+func TestPackage(t *testing.T) {
+	gc.TestingT(t)
+}