Skip to content

Commit

Permalink
Merge pull request juju#16538 from tlm/model-config-api
Browse files Browse the repository at this point in the history
juju#16538

Due to changes in the cloud state layer we had a todo to fix is controller cloud. This has been completed in previous PR's.

## Checklist

- [x] Code style: imports ordered, good names, simple structure, etc
- [x] Comments saying why design decisions were made
- ~[ ] Go unit tests, with comments saying what you're testing~
- ~[ ] [Integration tests](https://github.com/juju/juju/tree/main/tests), with comments saying what you're testing~
- ~[ ] [doc.go](https://discourse.charmhub.io/t/readme-in-packages/451) added or updated in changed packages~

## QA steps

This is just removing a TODO. The work to do the TODO was done in previous commits and unit tests exist asserting the behaviour.

## Documentation changes

N/A

## Links

**Jira card:** JUJU-4853
  • Loading branch information
jujubot authored Nov 5, 2023
2 parents 2fbde0b + e896ae5 commit 0fa59f0
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion domain/cloud/state/state.go
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,6 @@ ON CONFLICT(region_uuid, key) DO UPDATE

func loadClouds(ctx context.Context, tx *sql.Tx, name string) ([]cloud.Cloud, error) {
// First load the basic cloud info and auth types.
// TODO: needs controller cloud
q := `
SELECT cloud.uuid, cloud.name, cloud_type_id,
cloud.endpoint, cloud.identity_endpoint,
Expand Down

0 comments on commit 0fa59f0

Please sign in to comment.