Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes maliput::test_utilities dependency. #106

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Removes maliput::test_utilities dependency. #106

merged 2 commits into from
Oct 10, 2023

Conversation

francocipollone
Copy link
Collaborator

@francocipollone francocipollone commented Oct 9, 2023 •
edited
Loading

🎉 New feature

❗ Goes on top maliput/maliput#600
Part of maliput/maliput#602

Summary

  • Uses compare methods instead.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

action-ros-ci-repos-override: https://gist.githubusercontent.com/francocipollone/b4f12ba16f95b45495362ae94202e810/raw/9db4de603d3df5286ba77d7184ccc2301710bbd2/maliput_multilane.repos

agalbachicar
agalbachicar previously approved these changes Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@agalbachicar agalbachicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francocipollone
Updates CI
eac1f53 
Signed-off-by: Franco Cipollone <[email protected]>
@francocipollone francocipollone merged commit d91bbb2 into main Oct 10, 2023
2 checks passed
@francocipollone francocipollone deleted the francocipollone/dont_use_test_utilities branch October 10, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agalbachicar agalbachicar agalbachicar left review comments

Assignees
No one assigned
Labels
None yet
Projects
Maliput - Core development
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@francocipollone @agalbachicar