Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds tests to GenerateDotStream(). #85

Merged
merged 3 commits into from
Oct 9, 2024

Conversation

agalbachicar
Copy link
Collaborator

🎉 New feature

Complements maliput/maliput#637 and maliput/maliput#639

Summary

Provides test for the DOT serialization of graphs and routes.

Test it

Via colcon test

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Agustin Alba Chicar <[email protected]>
Copy link
Collaborator

@liangfok liangfok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completed a pass.

test/generate_dot_test.cc Outdated Show resolved Hide resolved
test/generate_dot_test.cc Outdated Show resolved Hide resolved
test/generate_dot_test.cc Show resolved Hide resolved
@agalbachicar agalbachicar requested a review from liangfok October 1, 2024 09:44
Copy link
Collaborator

@liangfok liangfok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agalbachicar agalbachicar merged commit b7283d8 into main Oct 9, 2024
3 checks passed
@agalbachicar agalbachicar deleted the agalbachicar/#543_extend_dot_files_with_routes branch October 9, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants