Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Rust API for Lane, RoadPosition, RoadPositionResult. #39

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Adds Rust API for Lane, RoadPosition, RoadPositionResult. #39

merged 2 commits into from
Mar 14, 2024

Conversation

francocipollone
Copy link
Contributor

@francocipollone francocipollone commented Mar 12, 2024 •
edited
Loading

Goes on top of #34

🎉 New feature

Related to #38 #28

Summary

Adds Rust api for :

  • Lane (partial)
  • RoadPosition(complete)
  • RoadPositionResult(complete)

Checklist

  • [] Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

This was referenced Mar 12, 2024
Open
Closed
agalbachicar
agalbachicar previously approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@agalbachicar agalbachicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from francocipollone/lane_road_position to main March 14, 2024 12:49
@francocipollone francocipollone dismissed agalbachicar’s stale review March 14, 2024 12:49

The base branch was changed.

@francocipollone francocipollone mentioned this pull request Mar 14, 2024
Merged
6 tasks
@francocipollone francocipollone merged commit d075f93 into main Mar 14, 2024
3 checks passed
@francocipollone francocipollone deleted the francocipollone/rust_api_lane_road_position branch March 14, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agalbachicar agalbachicar agalbachicar left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@francocipollone @agalbachicar