Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use impl AsRef<Path> for dirpath and fileroot args in generate_obj_file method #128

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Use impl AsRef<Path> for dirpath and fileroot args in generate_obj_file method #128

merged 2 commits into from
Nov 12, 2024

Conversation

francocipollone
Copy link
Contributor

@francocipollone francocipollone commented Nov 12, 2024 •
edited
Loading

🎉 New feature

Closes #127

  • ditto
  • It also adds some minor improvements

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

@francocipollone francocipollone merged commit 2a83f6b into main Nov 12, 2024
3 checks passed
@francocipollone francocipollone deleted the francocipollone/as_ref_obj branch November 12, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Santoi Santoi Awaiting requested review from Santoi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use impl AsRef<Path> for dirpath and fileroot args in generate_obj_file method.
1 participant
@francocipollone