Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds bindings/rust API for BulbGroup abstraction. #104

Merged
merged 1 commit into from
May 28, 2024
Merged

Adds bindings/rust API for BulbGroup abstraction. #104

merged 1 commit into from
May 28, 2024

Conversation

francocipollone
Copy link
Contributor

🎉 New feature

Related to :

Summary

  • Adds bindings for BulbGroup

  • Adds rust API for BulbGroup

  • Adds method for TrafficLights to get BulbGroups

  • Adds method for Bulbs to get BulbGroup

  • Tests are added.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

This was referenced May 21, 2024
Closed
Closed
Closed
Closed
Closed
agalbachicar
agalbachicar approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@agalbachicar agalbachicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francocipollone francocipollone merged commit 31ad365 into main May 28, 2024
3 checks passed
@francocipollone francocipollone deleted the francocipollone/bulb_group branch May 28, 2024 13:37
@francocipollone francocipollone mentioned this pull request May 28, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agalbachicar agalbachicar agalbachicar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@francocipollone @agalbachicar