Skip to content

Commit

Permalink
markdown links
Browse files Browse the repository at this point in the history
  • Loading branch information
malcomio committed Oct 29, 2024
1 parent d0834e4 commit fd27e8c
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions code-review/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ <h2>Accessibility</h2>
<p class="fragment">Keyboard users</p>
<p class="fragment">Hiding text appropriately?</p>
<p class="fragment">Hover and focus</p>
<p class="fragment">https://a11yproject.com/checklist.html</p>
<p class="fragment"><a href="https://www.a11yproject.com/checklist">https://www.a11yproject.com/checklist/</a></p>

<aside class="notes">
Getting accessibility right is difficult.
Expand Down Expand Up @@ -350,7 +350,7 @@ <h2 class="fragment">Maintainability</h2>
<h2>Code smells</h2>
<p class="fragment">
Larry Garfield at DrupalCon London 2011
https://www.youtube.com/watch?v=Z78ZP_UtaKE
<a href="https://www.youtube.com/watch?v=Z78ZP_UtaKE">https://www.youtube.com/watch?v=Z78ZP_UtaKE</a>
</p>
<ul class="fragment">
<li>And</li>
Expand Down Expand Up @@ -438,9 +438,9 @@ <h2 class="fragment">Don't make it personal</h2>
data-background-color="#FFF"
class="text-on-light">
<script type="text/template">
<p class="fragment">Set up your IDE:<br/>https://www.drupal.org/docs/develop/development-tools</p>
<p class="fragment">Pre-commit hooks:<br/>https://github.com/geraldvillorente/drupal-pre-commit</p>
<p class="fragment">Static analysis with Jenkins:<br/>http://reload.github.io/jenkins-drupal-template/</p>
<p class="fragment">Set up your IDE:<br/><a href="https://www.drupal.org/docs/develop/development-tools">https://www.drupal.org/docs/develop/development-tools</a></p>
<p class="fragment">Pre-commit hooks:<br/><a href="https://github.com/geraldvillorente/drupal-pre-commit">https://github.com/geraldvillorente/drupal-pre-commit</a></p>
<p class="fragment">Static analysis with Jenkins:<br/><a href="http://reload.github.io/jenkins-drupal-template/">http://reload.github.io/jenkins-drupal-template/</a></p>
<aside class="notes">
I'm a big coding standards pedant - improve signal to noise in dev and code review
But adding comments about whitespace is pretty tedious
Expand Down Expand Up @@ -516,6 +516,7 @@ <h2>Image credits</h2>
<section data-markdown data-background-color="#fff">
<script type="text/template">
<img src="../images/capgemini_logo.svg" class="no-border"/>

https://capgemini.github.io

https://malcomio.github.io/presentations/code-review
Expand Down

0 comments on commit fd27e8c

Please sign in to comment.