cmooney-20210430: Add note about skim()/thaw() #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdNoepel
suggested changes
Apr 30, 2021
EdNoepel
reviewed
Apr 30, 2021
| @@ -148,6 +148,11 @@ interface SpotLike { | |||
| all auctions are in the reverse (`dent`) phase. There are two ways | |||
| of ensuring this: | |||
|
|
|||
| NOTE: In the event there's a system surplus, and there are no | |||
| under-collateralised vaults remaining, one must skim() large CDPs in order | |||
There was a problem hiding this comment.
Is it only large CDPs? Seems like if we need 0 surplus we need to skim all non-empty CDPs.
There was a problem hiding this comment.
We shouldn't need to skim() everything, as we just need enough to collect fees get surplus to 0. The surplus cap means some of those fees are owed, but were sent off to surplus auctions. That is, surplus < all fees owed.
EdNoepel
reviewed
Apr 30, 2021
| @@ -148,6 +148,11 @@ interface SpotLike { | |||
| all auctions are in the reverse (`dent`) phase. There are two ways | |||
| of ensuring this: | |||
There was a problem hiding this comment.
This line references two options on old line 151 and 158. The new comment seems to be wedged in the middle
There was a problem hiding this comment.
Yeah, I'd suggest moving the new paragraph right after - backing collateral taken
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue came up when running the cage-keeper in
kovan. The documentation needs to be more clear.