Add 'Intro to Notion API' example #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessmitch42
requested review from
a team and
parulbaweja
and removed request for
a team
parulbaweja
previously approved these changes
Sep 5, 2023
| `NOTION_PAGE_ID`: Use the ID of any Notion page that you want to test adding content to. | ||
|
|
||
| The page ID is the 32 character string at the end of any page URL. | ||
|  |
There was a problem hiding this comment.
Is this supposed to be an example Notion page URL?
| } | ||
|
|
||
| // After adding pages, query the database entries (pages) | ||
| queryDatabase(databaseId) |
There was a problem hiding this comment.
would it be useful to add console.log("Querying database...")?
There was a problem hiding this comment.
sure thing, just added :)
|
Hey @parulbaweja thanks for the review. I added your suggestion so it looks like it needs another review. If everything looks good, do you mind merging it too after approving? I don't have permissions to merge in this repo 🥲 |
parulbaweja
approved these changes
Sep 6, 2023
rhart92
pushed a commit
that referenced
this pull request
Oct 3, 2023
* add new example (wip) * update readme * add intermediate example * add more comments and resources to each example * add additional resources section * rename some files for consistency, clean up readme, more console logs * make linter happy * readme updates * clean up links * add console for querying
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new example to the
/examplesdirectory. There was a request to have more code samples that build up in complexity so each section has a simple version that gets progressively more complex.There will be an
advancedsection added in a future PR (likely some existing examples moved over here to organize them a bit more).This can be easily expanded as more requests come in; for example, the current
/basicfiles can be grouped into ablockssubdirectory if other "basic" examples get requested.Note: Part of the request was to heavily comment this code here.