Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attachements to email steps output #213

Merged

Conversation

martinschaflitzl1
Copy link
Contributor

Adds the filenames of the attachments to the output of the "Then show me the emails" and the failure message of the "Then an email should have been sent with" step.

@martinschaflitzl1 martinschaflitzl1 changed the title Add attachements to email steps ouput Add attachements to email steps output Nov 14, 2024
Copy link
Contributor

@FLeinzi FLeinzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sieht gut aus, aber habe zwei kleine Anmerkungen.

spec/steps/show_me_the_mails_spec.rb Outdated Show resolved Hide resolved
lib/spreewald_support/mail_finder.rb Outdated Show resolved Hide resolved
@martinschaflitzl1 martinschaflitzl1 force-pushed the ms/add_attachement_header_to_email_step_message branch from 0b566a1 to 797f981 Compare November 14, 2024 16:50
@martinschaflitzl1 martinschaflitzl1 force-pushed the ms/add_attachement_header_to_email_step_message branch from 797f981 to 32d8a6f Compare November 14, 2024 16:57
@martinschaflitzl1 martinschaflitzl1 merged commit 32d8a6f into master Nov 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include the Attachment header when the "an email should have been sent with" step does not match
2 participants