Fix #205 #207
Merged
Fix #205 #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
begerdom
approved these changes
Dec 11, 2023
| ## 4.6.0 | ||
| - Spreewald not explicitly depends on Capybara. We don't expect anyone used it without Capybara in the first place. | ||
| - Changes to "the ... field should (not) have (an error|the error ...)" step: | ||
| - fixed an edgecases where errors were nested deeper inside a .field_with_errors element |
There was a problem hiding this comment.
Suggested change
| - fixed an edgecases where errors were nested deeper inside a .field_with_errors element | |
| - fixed an edgecase where errors were nested deeper inside a .field_with_errors element |
begerdom
reviewed
Dec 11, 2023
| end | ||
|
|
||
| def rails_error? | ||
| parent_element_classes = @element.find(:xpath, '..')[:class] &.split(' ') || [] | ||
| parent_element_classes.include?('field_with_errors') | ||
| has_xpath? do |x| |
There was a problem hiding this comment.
Brauchen wir dafür noch einen Test?
|
@kratob Thanks for the PR, I encountered the same issue and the changes reduce the execution time of an affected step from |
…XPath library to construct xpaths
kratob
force-pushed
the
tk/fix-rails-error
branch
from
df46cc0
to
06bab5e
Compare
|
Now released as 4.6.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #205.
Sped up the
FieldErrorFindersignificantly by setting Capybara.default_max_wait_time to 0. We are always called inside a patiently block anyways.