Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPAs, PWAs and SSR #300

Merged
merged 10 commits into from
Apr 5, 2019
Merged

SPAs, PWAs and SSR #300

merged 10 commits into from
Apr 5, 2019

Conversation

marcoow
Copy link
Member

@marcoow marcoow commented Mar 19, 2019

This is a blog post version of this talk: https://speakerdeck.com/marcoow/ssr-spas-and-pwas, the second part in the series layed out in https://github.com/simplabs/simplabs.github.io/issues/207

@marcoow marcoow requested a review from a team March 19, 2019 01:59
wadie
wadie reviewed Mar 19, 2019
View reviewed changes
Copy link
Contributor

@wadie wadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a useful read and the different paragraphs are well structured! 👍

blog/_posts/2019-03-16-spas-pwas-and-ssr.md Outdated Show resolved Hide resolved
blog/_posts/2019-03-16-spas-pwas-and-ssr.md Outdated Show resolved Hide resolved
blog/_posts/2019-03-16-spas-pwas-and-ssr.md Outdated Show resolved Hide resolved
blog/_posts/2019-03-16-spas-pwas-and-ssr.md Outdated Show resolved Hide resolved
Turbo87
Turbo87 reviewed Mar 19, 2019
View reviewed changes
blog/_posts/2019-03-16-spas-pwas-and-ssr.md Outdated Show resolved Hide resolved
blog/_posts/2019-03-16-spas-pwas-and-ssr.md Outdated Show resolved Hide resolved
blog/_posts/2019-03-16-spas-pwas-and-ssr.md Outdated Show resolved Hide resolved
blog/_posts/2019-03-16-spas-pwas-and-ssr.md Show resolved Hide resolved
jayjayjpg
jayjayjpg approved these changes Apr 4, 2019
View reviewed changes
Copy link
Contributor

@jayjayjpg jayjayjpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads great ✨ I really enjoyed reading it and find it very detailed and descriptive. I left a few more suggestions, but otherwise this seems good to go

blog/_posts/2019-03-16-spas-pwas-and-ssr.md Outdated Show resolved Hide resolved
blog/_posts/2019-03-16-spas-pwas-and-ssr.md Outdated Show resolved Hide resolved
@marcoow marcoow merged commit 6c644d3 into master Apr 5, 2019
@delete-merged-branch delete-merged-branch bot deleted the spa-pwa-ssr branch April 5, 2019 07:06
@marcoow marcoow mentioned this pull request Apr 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wadie wadie wadie left review comments

@Turbo87 Turbo87 Turbo87 left review comments

@jayjayjpg jayjayjpg jayjayjpg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marcoow @Turbo87 @wadie @jayjayjpg