Skip to content

Commit

Permalink
Attempt to reproduce the issue
Browse files Browse the repository at this point in the history
  • Loading branch information
lolmaus committed Nov 15, 2023
1 parent 38f425c commit 95323ec
Show file tree
Hide file tree
Showing 4 changed files with 12,361 additions and 3 deletions.
15 changes: 15 additions & 0 deletions app/controllers/application.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
import Controller from '@ember/controller';
import { recordIdentifierFor } from '@ember-data/store';
import { macroCondition } from '@embroider/macros';


export default class ApplicationController extends Controller {}

console.log(recordIdentifierFor);

if (macroCondition(true)) {
console.log(true);
} else if (macroCondition(false)) {
// this branch will never be hit and furthermore in production
// builds it will be fully removed
}
9 changes: 9 additions & 0 deletions ember-cli-build.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,19 @@ const EmberApp = require('ember-cli/lib/broccoli/ember-app');
module.exports = function (defaults) {
const app = new EmberApp(defaults, {
// Add options here
'@embroider/macros': {
setConfig: {
'@ember-data/store': {
polyfillUUID: true,
},
},
},
});

const { Webpack } = require('@embroider/webpack');
return require('@embroider/compat').compatBuild(app, Webpack, {
staticAddonTestSupportTrees: true,
staticAddonTrees: true,
skipBabel: [
{
package: 'qunit',
Expand Down
7 changes: 4 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,10 @@
"@ember/optional-features": "^2.0.0",
"@ember/string": "^3.0.1",
"@ember/test-helpers": "^2.9.3",
"@embroider/compat": "^2.1.1",
"@embroider/core": "^2.1.1",
"@embroider/webpack": "^2.1.1",
"@embroider/compat": "^3.3.0",
"@embroider/core": "^3.4.0",
"@embroider/router": "^2.1.5",
"@embroider/webpack": "^3.2.1",
"@glimmer/component": "^1.1.2",
"@glimmer/tracking": "^1.1.2",
"broccoli-asset-rev": "^3.0.0",
Expand Down
Loading

0 comments on commit 95323ec

Please sign in to comment.