Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action helper and modifier are deprecated in login-form.hbs #2860

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Action helper and modifier are deprecated in login-form.hbs #2860

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/test-app/app/templates/components/login-form.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,20 @@
{{! login form; the fields must be named "identification" and "password"; the controller action is "authenticate" }}
<a {{action 'authenticateWithFacebook'}} class="btn btn-primary" href="#" role="button">Login with Facebook</a>
<a {{on 'click' this.authenticateWithFacebook}} class="btn btn-primary" href="#" role="button">Login with Facebook</a>
<hr/>
<a {{action 'authenticateWithGoogleImplicitGrant'}} class="btn btn-primary" href="#" role="button">Login with Google (Implicit Grant)</a>
<a {{on 'click' this.authenticateWithGoogleImplicitGrant}} class="btn btn-primary" href="#" role="button">Login with Google (Implicit Grant)</a>
<hr/>
<p>or login with OAuth 2.0 <em>Resource Owner Password Credentials</em>:</p>
<form {{action 'authenticateWithOAuth2' on='submit'}}>
<div class="form-group">
<label for="identification">Login</label>
<input type="text" placeholder="Enter Login" class="form-control" onchange={{action 'updateIdentification'}} value={{this.identification}} data-test-identification />
<input type="text" placeholder="Enter Login" class="form-control" {{on 'change' this.updateIdentification}} value={{this.identification}} data-test-identification />
</div>
<div class="form-group">
<label for="password">Password</label>
<input type="password" placeholder="Enter Password" class="form-control" onchange={{action 'updatePassword'}} value={{this.password}} data-test-password />
<input type="password" placeholder="Enter Password" class="form-control" {{on 'change' this.updatePassword}} value={{this.password}} data-test-password />
</div>
<div class="form-group form-check">
<input type="checkbox" class="form-check-input" id="rememberMe" onchange={{action 'updateRememberMe'}} checked={{this.rememberMe}} />
<input type="checkbox" class="form-check-input" id="rememberMe" {{on 'change' this.updateRememberMe}} checked={{this.rememberMe}} />
<label for="rememberMe" class="form-check-label">
Remember me
</label>
Expand Down
Loading