Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing dependent key in README #2291

Merged
merged 1 commit into from
May 8, 2021
Merged

add missing dependent key in README #2291

merged 1 commit into from
May 8, 2021

Conversation

marcoow
Copy link
Member

@marcoow marcoow commented Apr 23, 2021

The headers CP in the adapter example relies on both this.session.data.authenticated.access_token and this.session.isAuthenticated but only specifies session.data.authenticated.access_token as a dependent key which triggers a linter error:

Use of undeclared dependencies in computed property: session.isAuthenticated ember/require-computed-property-dependencies

This adds the missing key to the README.

addresses (part of) #2289

@marcoow marcoow requested a review from a team April 23, 2021 08:12
@marcoow marcoow force-pushed the fix-readme-exampl branch from 85204d2 to 3e9af51 Compare May 7, 2021 12:46
@marcoow marcoow merged commit 5e7e0e3 into master May 8, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix-readme-exampl branch May 8, 2021 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants