Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use computed properties with native classes. #2289

Open
rinoldsimon opened this issue Apr 21, 2021 · 0 comments
Open

Don't use computed properties with native classes. #2289

rinoldsimon opened this issue Apr 21, 2021 · 0 comments

Comments

@rinoldsimon
Copy link

Have implemented ember-simple-auth as per the guides here https://github.com/simplabs/ember-simple-auth
Have followed the walkthrough https://github.com/simplabs/ember-simple-auth#walkthrough

Upon running npm run lint:js the line

import { computed } from '@ember/object'; and 
....
@computed('session.data.authenticated.access_token')

throws the below errors
Don't use computed properties with native classes. Use getters or @tracked properties instead ember/no-computed-properties-in-native-classes

Use of undeclared dependencies in computed property: session.isAuthenticated ember/require-computed-property-dependencies

Not sure how to fix the above errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant