feat: remove support for deprecated modal-from-string

mainmatter · Feb 7, 2024 · d778c6c · d778c6c
1 parent 7394a5c
commit d778c6c
Show file tree

Hide file tree

Showing 5 changed files with 1 addition and 107 deletions.
diff --git a/DEPRECATIONS.md b/DEPRECATIONS.md
diff --git a/addon/services/modals.js b/addon/services/modals.js
@@ -1,5 +1,4 @@
 import { A } from '@ember/array';
-import { deprecate } from '@ember/debug';
 import { computed } from '@ember/object';
 import { alias } from '@ember/object/computed';
 import Service from '@ember/service';
@@ -41,20 +40,6 @@ export default Service.extend({
    * @returns {Modal}
    */
   open(componentClass, data, options) {
-    deprecate(
-      `Ember Promise Modals: For extended compatibility with Embroider and its tree-shaking ability, you need to import and pass in the component class of the modal component you want to display instead of "${componentClass}".`,
-      typeof componentClass !== 'string',
-      {
-        id: 'ember-promise-modals.modals-from-string',
-        until: '5.0.0',
-        for: 'ember-promise-modals',
-        since: {
-          enabled: '3.1.0',
-        },
-        url: 'https://github.com/mainmatter/ember-promise-modals/blob/main/DEPRECATIONS.md#ember-promise-modalsmodals-from-string',
-      },
-    );
-
     let modal = new Modal(this, componentClass, data, options);
 
     this._stack.pushObject(modal);

diff --git a/config/ember-try.js b/config/ember-try.js
@@ -97,11 +97,7 @@ module.exports = async function () {
         },
       },
       embroiderSafe(),
-      embroiderOptimized({
-        env: {
-          SKIP_EMBROIDER_DEPRECATION_TEST: true,
-        },
-      }),
+      embroiderOptimized(),
     ],
   };
 };
diff --git a/tests/application/deprecations-test.js b/tests/application/deprecations-test.js
diff --git a/tests/dummy/config/environment.js b/tests/dummy/config/environment.js
@@ -33,7 +33,6 @@ module.exports = function (environment) {
 
   if (environment === 'test') {
     // Testem prefers this...
-    ENV.SKIP_EMBROIDER_DEPRECATION_TEST = process.env.SKIP_EMBROIDER_DEPRECATION_TEST;
     ENV.locationType = 'none';
 
     // keep test console output quieter