test in Firefox on CI #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IMHO the bugfix belongs in a separate PR, but since we're writing a manual changelog here it might not matter that much. still makes it somewhat harder to review though... |
|
@simplabs/engineering anyone care to review? |
|
@jessica-jordan I don't have a reference and I'm not sure it's really a bug in Firefox. It's something where it behaves differently than other browsers but I'm not sure what the exact spec is for this or whether there is a spec that covers this at all. The tests fail in Firefox though without this change. |
|
Thank you for the outline, I think you're right that it makes most sense to provide a fallback path then 👍 |
jayjayjpg
approved these changes
Mar 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Firefox to the browsers we test with in CI; see #152 (comment)
It also includes a fix for a bug (or different behavior compared to Chrome) in Firefox: Firefox will set the default cookie path with a trailing slash (e.g.
/some/path/) while Chrome would set it without the trailing slash (e.g./some/path). In order to make the behavior the same for all browsers, this changes thecookiesservice so that it would automatically set a normalized defaultpath(/some/pathin the above example) if none was specified. I'm not really happy with this (as writing a cookie via thecookiesservice will now result in a different cookie than just usingdocument.cookie =) but couldn't really think of a better solution 🤔