-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix handling of non-UTF8 sequences in path rewrites #32
Conversation
4a8f85c
to
375369b
Compare
375369b
to
cb35fd2
Compare
@LukeMathWalker Re this comment on #28 Supporting workspaces that are located at paths containing non-UTF-8 segments is going to require some rethinking. The problem with the implementation in this PR is that it rewrites the dependency paths to absolute paths, which may contain such segments, and stores them in the However, the current implementation uses I think the best course of action here is to panic when |
cb35fd2
to
1fc81f0
Compare
OK, let's keep it simple for now. |
1fc81f0
to
4287c0e
Compare
Sorry for the churn here -- I mentally noted that I agree with @hdoordt, this seems like a good solution to me! |
@cbgbt Don't feel bad, as a reviewer, I should have caught this one. |
Addresses comments (1 and 2) in #28