-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos in 03_ticket_v1/12_outro test #170
Conversation
✅ Deploy Preview for taupe-lily-3539f6 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
The build is failing when trying to checkout https://github.com/mainmatter/core-sans-a-fonts. Error says the checkout action doesn't find the default branch, but when explicitly setting the branch as 'main', it doesn't find the repo at all. (I've since removed the troubleshooting commit that tried to set the ref) Found these related issues, but no clear solution (to me) - might be related to permissions: actions/checkout#347 I'm setting this PR as draft until I'm able to resolve it. Luca, hopefully you'll have a clear idea of what's going on :) |
I don't know about the permissions (@marcoow?), but the refs there are intentional! |
Yeah, you don't have access to the repo from a fork – I see that's a bit limiting, maybe we shouldn't be building the PDF on forks or use a fallback font or so… |
@LukeMathWalker wdyt? Shall we just build |
We could use a fallback font, so that we are sure it builds correctly at the very least. |
yeah I agree that's better 👍 |
Ok! I wasn't familiar with values as references like this :) I'll close this and go back to the exercise, then |
No description provided.