Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in 03_ticket_v1/12_outro test #170

Closed
wants to merge 1 commit into from

Conversation

oliverbarnes
Copy link

No description provided.

Copy link

netlify bot commented Oct 13, 2024

Deploy Preview for taupe-lily-3539f6 ready!

Name Link
🔨 Latest commit 4b2bd5e
🔍 Latest deploy log https://app.netlify.com/sites/taupe-lily-3539f6/deploys/670c0fdea5437b0008b501fc
😎 Deploy Preview https://deploy-preview-170--taupe-lily-3539f6.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@oliverbarnes
Copy link
Author

The build is failing when trying to checkout https://github.com/mainmatter/core-sans-a-fonts. Error says the checkout action doesn't find the default branch, but when explicitly setting the branch as 'main', it doesn't find the repo at all.

(I've since removed the troubleshooting commit that tried to set the ref)

Found these related issues, but no clear solution (to me) - might be related to permissions:

actions/checkout#347
actions/checkout#417

I'm setting this PR as draft until I'm able to resolve it. Luca, hopefully you'll have a clear idea of what's going on :)

@LukeMathWalker
Copy link
Collaborator

I don't know about the permissions (@marcoow?), but the refs there are intentional!
At this stage we haven't yet discussed Copy types.

@marcoow
Copy link
Member

marcoow commented Oct 14, 2024

Yeah, you don't have access to the repo from a fork – I see that's a bit limiting, maybe we shouldn't be building the PDF on forks or use a fallback font or so…

@marcoow
Copy link
Member

marcoow commented Oct 14, 2024

@LukeMathWalker wdyt? Shall we just build main?

@LukeMathWalker
Copy link
Collaborator

We could use a fallback font, so that we are sure it builds correctly at the very least.

@marcoow
Copy link
Member

marcoow commented Oct 14, 2024

yeah I agree that's better 👍

@oliverbarnes
Copy link
Author

but the refs there are intentional!
At this stage we haven't yet discussed Copy types.

Ok! I wasn't familiar with values as references like this :) I'll close this and go back to the exercise, then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants