Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add instructions to override settings using ActionMailer callbacks #176

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jgigault
Copy link

Note: This commit also includes an update of .gitignore file for IntelliJ IDEs users

I was looking for a solution to temporary override Mailjet credentials without having to specify api_key and secret_key params within delivery_method_options of all my mailers.
The idea of using callbacks is to keep the mailers very clean, but it requires to manually map Mailjet settings with raw user_name and password SMTP settings.

I am wondering if this tip should be part of the README, but I wanted to share it to you.
Please give me feedbacks if you think about a better integrated solution.

@francois-ferrandis
Copy link

I was faced with the exact same problem, and since the Rails documentation is misleading on this matter, it took me a while to realize I could use an after_action callback.

In my opinion, this PR should be merged. 👍

Note : @jgigault perhaps you could rebase and push --force so it would trigger the CI again and probably pass! 😉

@jgigault
Copy link
Author

jgigault commented Jan 6, 2021

Nice to see you there @francois-ferrandis :-) Now I am feeling not alone with my proposal!

this commit also includes an update of .gitignore file for IntelliJ IDEs users
@jgigault jgigault force-pushed the readme/override-defaults-using-callback branch from 49e2365 to 7f276fc Compare January 10, 2021 16:22
@boardfish
Copy link

I experienced #219 while trying to implement something along these lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants