Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/admin style #31

Merged
merged 10 commits into from
Jun 18, 2024
Merged

Feat/admin style #31

merged 10 commits into from
Jun 18, 2024

Conversation

nateconley
Copy link
Collaborator

Description of the Change

  • Changes style of the admin settings page
  • Removes IE-specific stylesheet
  • Changes "MailChimp" to "Mailchimp"
  • Updates markup for accessibility (labels on inputs, etc)

Closes #6

How to test the Change

(From #6) Creating the below checklist of items to update per the Figma updates from Eddie Shrake:

  • Update header in Settings page to Freddie icon (40x40), bg color: white (#FFFFFF), border-top: 2px (#FFE01B), title as "Mailchimp List Subscribe Form" in #241C15
  • Change ALL buttons and links to Kale (#007C89)
  • Change ALL instances of "MailChimp" to "Mailchimp" (note I think this is likely already done in Update/dotorg standards #14 but worth double checking on the Settings page in any case)
  • Change ALL section backgrounds and borders to Squash (#FBEECA)
  • Change ALL section titles to Black/Peppercorn (#241C15)

Changelog Entry

Changed - Admin styles to match comp
Deprecated - Removes IE-specific admin stylesheet
Fixed - Accessibility for admin settings page

Credits

@nateconley

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly. - n/a
  • I have added tests to cover my change.
  • All new and existing tests pass.

@nateconley nateconley requested a review from dkotter June 17, 2024 05:45
@nateconley nateconley self-assigned this Jun 17, 2024
@github-actions github-actions bot added this to the 1.6.0 milestone Jun 17, 2024
@github-actions github-actions bot added the needs:code-review This requires code review. label Jun 17, 2024
Copy link
Collaborator

@dkotter dkotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple additional notes:

There's some links on the main setup page that aren't the right color yet:

Wrong link colors

If I try and connect with no API key or an invalid key, the error message needs more spacing (and maybe change to a red color, though that's my opinion):

Error message

views/setup_page.php Outdated Show resolved Hide resolved
views/setup_page.php Outdated Show resolved Hide resolved
views/setup_page.php Show resolved Hide resolved
icon.svg Outdated Show resolved Hide resolved
@dkotter
Copy link
Collaborator

dkotter commented Jun 17, 2024

One other thing I'm seeing is the Powered by WordPress footer link is overlapping the left-side nav bar when on the initial settings screen (seems to be fine once you're connected). I'm guessing there's some markup or styling issues in what is output on this settings screen that's causing this:

Footer link overlap

@nateconley
Copy link
Collaborator Author

@dkotter I have addressed all of your comments and this is ready for re-review. Thank you!

@jeffpaul jeffpaul requested a review from dkotter June 18, 2024 19:54
@dkotter dkotter merged commit 2660485 into develop Jun 18, 2024
4 checks passed
@dkotter dkotter deleted the feat/admin-style branch June 18, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:code-review This requires code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Mailchimp brand treatments
2 participants