Fixes and cleanup of a bunch of things phpstan discovered on level 0

Controller/Adminhtml/Batch/Index.php

@@ -28,9 +28,9 @@ public function __construct(
         \Magento\Backend\App\Action\Context $context,
         \Magento\Framework\View\Result\PageFactory $resultPageFactory
     ) {
-
         $this->resultPageFactory = $resultPageFactory;
-        return parent::__construct($context);
+
+        parent::__construct($context);
     }
     public function execute()
     {

Controller/Adminhtml/Cron/Index.php

@@ -28,9 +28,9 @@ public function __construct(
         \Magento\Backend\App\Action\Context $context,
         \Magento\Framework\View\Result\PageFactory $resultPageFactory
     ) {
-
         $this->resultPageFactory = $resultPageFactory;
-        return parent::__construct($context);
+
+        parent::__construct($context);
     }
     public function execute()
     {

Controller/Adminhtml/Errors/Index.php

@@ -28,9 +28,9 @@ public function __construct(
         \Magento\Backend\App\Action\Context $context,
         \Magento\Framework\View\Result\PageFactory $resultPageFactory
     ) {
-
         $this->resultPageFactory = $resultPageFactory;
-        return parent::__construct($context);
+
+        parent::__construct($context);
     }
     public function execute()
     {

Controller/Adminhtml/Orders/Campaign.php

@@ -50,10 +50,10 @@ public function execute()
             $campaign = $api->campaigns->get($order->getMailchimpCampaignId());
             $webId = $campaign['web_id'];
             $url = $this->urlBuilder->getUrl('https://admin.mailchimp.com/reports/summary') . "?id=$webId";
-            $this->_redirect($url);
+            return $this->_redirect($url);
         } catch(\Exception $e) {
             $this->messageManager->addErrorMessage($e->getMessage());
-            $this->_redirect($this->urlBuilder->getUrl('sales/order'));
+            return $this->_redirect($this->urlBuilder->getUrl('sales/order'));
         }
     }
     protected function _isAllowed()

Controller/Adminhtml/Orders/Member.php

@@ -52,10 +52,10 @@ public function execute()
             $member = $api->lists->members->get($listId, hash('md5', strtolower($email)));
             $memberId = $member['contact_id'];
             $url = $this->urlBuilder->getUrl('https://admin.mailchimp.com/audience/contact-profile') . "?contact_id=$memberId";
-            $this->_redirect($url);
+            return $this->_redirect($url);
         } catch(\Exception $e) {
             $this->messageManager->addErrorMessage($e->getMessage());
-            $this->_redirect($this->urlBuilder->getUrl('sales/order'));
+            return $this->_redirect($this->urlBuilder->getUrl('sales/order'));
         }
     }
     protected function _isAllowed()

Controller/Checkout/Success.php

@@ -108,7 +108,8 @@ public function execute()
             $this->_helper->log($e->getMessage());
         }
         $this->messageManager->addSuccessMessage(__('Thanks for sharing your interest with us'));
-        $this->_redirect($this->_helper->getBaserUrl(
+
+        return $this->_redirect($this->_helper->getBaserUrl(
             $order->getStoreId(),
             \Magento\Framework\UrlInterface::URL_TYPE_WEB
         ));

Setup/Patch/Data/Migrate24.php

@@ -36,6 +36,8 @@ public function apply()
         $this->moduleDataSetup->getConnection()->query($query);
 
         $this->moduleDataSetup->getConnection()->endSetup();
+
+        return $this;
     }
     public static function getDependencies()
     {

Setup/Patch/Data/Migrate32.php

@@ -75,6 +75,8 @@ public function apply()
             }
         }
         $this->moduleDataSetup->getConnection()->endSetup();
+
+        return $this;
     }
     public static function getDependencies()
     {

Setup/Patch/Data/Migrate35.php

@@ -48,10 +48,10 @@ public function apply()
          */
         foreach ($configCollection as $config) {
             try {
-                $config->setValue($this->_helper->encrypt($config->getvalue()));
+                $config->setValue($this->helper->encrypt($config->getvalue()));
                 $config->getResource()->save($config);
             } catch (\Exception $e) {
-                $this->_helper->log($e->getMessage());
+                $this->helper->log($e->getMessage());
             }
         }
         $configCollection = $this->configFactory->create();
@@ -64,6 +64,8 @@ public function apply()
         }
 
         $this->moduleDataSetup->getConnection()->endSetup();
+
+        return $this;
     }
     public static function getDependencies()
     {

Setup/Patch/Data/Migrate452.php

@@ -89,6 +89,8 @@ public function apply()
         }
 
         $this->moduleDataSetup->getConnection()->endSetup();
+
+        return $this;
     }
 
     public static function getDependencies()

Ui/Component/Batch/Grid/Column/Batches.php

@@ -53,7 +53,7 @@ public function __construct(
         array $components = [],
         array $data = []
     ) {
-        $this->_helper = $helper;
+        $this->helper = $helper;
         $this->mailChimpSyncB = $mailChimpSyncB;
         $this->urlBuilder = $urlBuilder;
         parent::__construct($context, $uiComponentFactory, $components, $data);
@@ -96,7 +96,7 @@ public function prepareDataSource(array $dataSource)
     private function getMCStoreNameById($mailchimp_store_id, $magentoStoreId)
     {
         if (!key_exists($mailchimp_store_id, $this->stores)) {
-            $api = $this->_helper->getApi($magentoStoreId);
+            $api = $this->helper->getApi($magentoStoreId);
             $store = $api->ecommerce->stores->get($mailchimp_store_id);
             $this->stores[$mailchimp_store_id] = $store['name'];
         }

view/frontend/templates/loadquote.phtml

@@ -11,11 +11,3 @@
 // Add your template code here ...
 
 ?>
-
-
-
-
-
-
-
-