Skip to content

Commit

Permalink
Merge pull request #1170 from mailchimp/pre-release/1.1.20
Browse files Browse the repository at this point in the history
Pre release/1.1.20
  • Loading branch information
Santiagoebizmarts authored Mar 30, 2020
2 parents 215ea17 + cf97015 commit 270db22
Show file tree
Hide file tree
Showing 28 changed files with 1,946 additions and 648 deletions.
29 changes: 23 additions & 6 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,30 @@
# Changelog
## [1.1.19](https://github.com/mailchimp/mc-magento/releases/tag/1.1.19) - 2020-01-03
## [1.1.20](https://github.com/mailchimp/mc-magento/releases/tag/1.1.20) - 2020-03-30
**Fixed**
- Not sending emails using Mandrill when new customer register. [\#1159](https://github.com/mailchimp/mc-magento/issues/1159)
- Mandrill configuration showing: --- Invalid API KEY --- even if API key is correct [\#1157](https://github.com/mailchimp/mc-magento/issues/1157)
- Warning: include(Ebizmarts/MailChimp/Model/Resource/Ecommercesyncdata/Promorules/Collection.php): failed to open stream: No such file or directory in /data/web/jenkins/public/builds/current/lib/Varien/Autoload.php on line 94 [\#1156](https://github.com/mailchimp/mc-magento/issues/1156)
- Limit local length of Merge Field to be the same size as in Mailchimp. [\#1140](https://github.com/mailchimp/mc-magento/issues/1140)
- Loading animation remains forever if there are no lists in the account after placing API Key [\#1136](https://github.com/mailchimp/mc-magento/issues/1136)
- Remove the mc_eid logic. [\#1141](https://github.com/mailchimp/mc-magento/issues/1141)
- Javascript error in campaignCatcher.js [\#1147](https://github.com/mailchimp/mc-magento/issues/1147)

**Changed**
- Only 10 interest group checkboxes showed after checkout [\#1135](https://github.com/mailchimp/mc-magento/issues/1135)
- Add Customer data update based on map fields in webhook [\#1110](https://github.com/mailchimp/mc-magento/issues/1110)
- Add explanation on warning when clicking Resend and Reset buttons with what scope will be deleted. [\#1142](https://github.com/mailchimp/mc-magento/issues/1142)

## [1.1.19](https://github.com/mailchimp/mc-magento/releases/tag/1.1.19) - 2020-03-03
**Fixed**
- Serializer error when Magento is compiled. [\#1116](https://github.com/mailchimp/mc-magento/issues/1116)
- Missing getWebhooks() function on Lib. [\#1115](https://github.com/mailchimp/mc-magento/issues/1115)
- Error in Cron error while executing mailchimp_clear_ecommerce_data [\#1112](https://github.com/mailchimp/mc-magento/issues/1112)
- Fix incorrect class declaration in function setEcommerceSyncDataItemValues [\#1103](https://github.com/mailchimp/mc-magento/issues/1103)

**Changed**
- Refactor collection filters to avoid doing joins, where, etc outside resources. [\#1119](https://github.com/mailchimp/mc-magento/issues/1119)
- Allow translation of texts on app/code/community/Ebizmarts/MailChimp/controllers/CartController.php [\#1118](https://github.com/mailchimp/mc-magento/issues/1118)
- Add Customer Interest Groups update based on webhook [\#1111](https://github.com/mailchimp/mc-magento/issues/1111)
- Add Mailchimp configuration link at Newsletter -> Mailchimp menu [\#1107](https://github.com/mailchimp/mc-magento/issues/1107)
- Log the product id if is not supported by Mailchimp [\#1101](https://github.com/mailchimp/mc-magento/issues/1101)
- Exceptions not treated properly. [\#1098](https://github.com/mailchimp/mc-magento/issues/1098)
Expand All @@ -12,11 +34,6 @@
- Unify Ecommerce Items Classes [\#1064](https://github.com/mailchimp/mc-magento/issues/1064)
- Create option in backend adminhtml to subsribe customers [\#450](https://github.com/mailchimp/mc-magento/issues/450)

**Fixed**
- Serializer error when Magento is compiled. [\#1116](https://github.com/mailchimp/mc-magento/issues/1116)
- Missing getWebhooks() function on Lib. [\#1115](https://github.com/mailchimp/mc-magento/issues/1115)
- Fix incorrect class declaration in function setEcommerceSyncDataItemValues [\#1103](https://github.com/mailchimp/mc-magento/issues/1103)

## [1.1.18](https://github.com/mailchimp/mc-magento/releases/tag/1.1.18) - 2019-10-07
**Changed**
- Avoid sending carts until the initial sync finishes [\#1073](https://github.com/mailchimp/mc-magento/issues/1073)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ protected function _renderCellTemplate($columnName)
$rendered .= '</select>';
} else {
return
'<input type="text" name="'
'<input type="text" maxlength="10" name="'
. $inputName . '" value="#{' . $columnName . '}" '
. ($column['size'] ? 'size="' . $column['size'] . '"' : '') . '/>';
}
Expand Down
29 changes: 22 additions & 7 deletions app/code/community/Ebizmarts/MailChimp/Helper/Curl.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,15 @@
class Ebizmarts_MailChimp_Helper_Curl extends Mage_Core_Helper_Abstract
{
/**
* @param array $options
* @return array An array with...
* @var Mage_HTTP_Client_Curl
*/
protected $_curl;
/**
* @param $url
* @param $httpMethod
* @param array $curlOptions
* @param array $params
* @return array
*/
public function curlExec($url, $httpMethod, $curlOptions = array(), $params = array())
{
Expand All @@ -30,28 +37,36 @@ public function curlExec($url, $httpMethod, $curlOptions = array(), $params = ar
}

$curlError = null;
$curl = new Mage_HTTP_Client_Curl();
$this->_curl = new Mage_HTTP_Client_Curl();

foreach ($curlOptions as $key => $value) {
if (isset($value)) {
$curl->setOption($key, $value);
$this->_curl->setOption($key, $value);
}
}

$curlResult = null;

try {
if ($httpMethod == Zend_Http_Client::GET) {
$curl->get($url);
$this->_curl->get($url);
} elseif ($httpMethod == Zend_Http_Client::POST) {
$curl->post($url, $params);
$this->_curl->post($url, $params);
}

$curlResult = $curl->getBody();
$curlResult = $this->_curl->getBody();
} catch (Exception $e) {
$curlError = $e->getMessage();
}

return array('response' => $curlResult, 'error' => $curlError);
}

/**+
* @return int
*/
public function getStatus()
{
return $this->_curl->getStatus();
}
}
2 changes: 1 addition & 1 deletion app/code/community/Ebizmarts/MailChimp/Helper/Data.php
Original file line number Diff line number Diff line change
Expand Up @@ -4464,7 +4464,7 @@ public function getInterest($storeId)
$apiInterestCategoryInterest = $apiInterestCategory->getInterests();

foreach ($interest as $interestId) {
$mailchimpInterest = $apiInterestCategoryInterest->getAll($listId, $interestId);
$mailchimpInterest = $apiInterestCategoryInterest->getAll($listId, $interestId, null, null, 100);

foreach ($mailchimpInterest['interests'] as $mi) {
$rc[$mi['category_id']]['category'][$mi['display_order']] =
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
<?php

class Ebizmarts_MailChimp_Model_Adminhtml_Resendecommercedata_Comment
{
/**
* @var Ebizmarts_MailChimp_Helper_Data
*/
protected $_mcHelper;

public function __construct()
{
$this->setMcHelper();
}

/**
* @return Ebizmarts_MailChimp_Helper_Data
*/
public function getMcHelper()
{
return $this->_mcHelper;
}

/**
* @param Ebizmarts_MailChimp_Helper_Data $mcHelper
*/
public function setMcHelper()
{
$this->_mcHelper = Mage::helper('mailchimp');
}

/**
* @return string
*/
public function getCommentText()
{
$helper = $this->getMcHelper();
$scopeArray = $helper->getCurrentScope();
$scope = $scopeArray['scope'];

if ($scope === "default"){
$comment = $helper->__("This will resend the ecommerce data "
."for all Websites and Store Views.");
} else {
$websiteOrStoreViewScope = $this->_getScope($scopeArray);
$comment = $helper->__("This will resend the ecommerce data "
."for %s only.", $websiteOrStoreViewScope);
}

return $comment;
}

/**
* @param $scopeArray
* @return string
*/
protected function _getScope($scopeArray)
{
$scope = $scopeArray['scope'];
if ($scope == "websites"){
$result = "this Website";
} else {
$result = "this Store View";
}

return $result;
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
<?php

class Ebizmarts_MailChimp_Model_Adminhtml_Resendsubscribers_Comment
{
/**
* @var Ebizmarts_MailChimp_Helper_Data
*/
protected $_mcHelper;

public function __construct()
{
$this->setMcHelper();
}

/**
* @return Ebizmarts_MailChimp_Helper_Data
*/
public function getMcHelper()
{
return $this->_mcHelper;
}

/**
* @param Ebizmarts_MailChimp_Helper_Data $mcHelper
*/
public function setMcHelper()
{
$this->_mcHelper = Mage::helper('mailchimp');
}

/**
* @return string
*/
public function getCommentText()
{
$helper = $this->getMcHelper();
$scopeArray = $helper->getCurrentScope();
$scope = $scopeArray['scope'];

if ($scope === "default"){
$comment = $helper->__("This will resend the subscribers "
."for all Websites and Store Views.");
} else {
$websiteOrStoreViewScope = $this->_getScope($scopeArray);
$comment = $helper->__("This will resend the subscribers "
."for %s only.", $websiteOrStoreViewScope);
}

return $comment;
}

/**
* @param $scopeArray
* @return string
*/
protected function _getScope($scopeArray)
{
$scope = $scopeArray['scope'];
if ($scope == "websites"){
$result = "this Website";
} else {
$result = "this Store View";
}

return $result;
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
<?php

class Ebizmarts_MailChimp_Model_Adminhtml_Reseterrors_Comment
{
/**
* @var Ebizmarts_MailChimp_Helper_Data
*/
protected $_mcHelper;

public function __construct()
{
$this->setMcHelper();
}

/**
* @return Ebizmarts_MailChimp_Helper_Data
*/
public function getMcHelper()
{
return $this->_mcHelper;
}

/**
* @param Ebizmarts_MailChimp_Helper_Data $mcHelper
*/
public function setMcHelper()
{
$this->_mcHelper = Mage::helper('mailchimp');
}

/**
* @return string
*/
public function getCommentText()
{
$helper = $this->getMcHelper();
$scopeArray = $helper->getCurrentScope();
$scope = $scopeArray['scope'];

if ($scope == "default"){
$comment = $helper->__("This will reset the errors "
."for all Websites and Store Views.");
} else {
$websiteOrStoreViewScope = $this->_getScope($scopeArray);
$comment = $helper->__("This will reset the errors "
."for %s only.", $websiteOrStoreViewScope);
}

return $comment;
}

/**
* @param $scopeArray
* @return string
*/
protected function _getScope($scopeArray)
{
$scope = $scopeArray['scope'];
if ($scope == "websites"){
$result = "this Website";
} else {
$result = "this Store View";
}

return $result;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -473,7 +473,7 @@ public function createEcommercePromoCodesCollection()
/**
* @var $collection Ebizmarts_MailChimp_Model_Resource_Ecommercesyncdata_PromoCodes_Collection
*/
$collection = Mage::getResourceModel('mailchimp/ecommercesyncdata_promocodes_collection');
$collection = Mage::getResourceModel('mailchimp/ecommercesyncdata_promoCodes_collection');

return $collection;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -455,7 +455,7 @@ public function createEcommercePromoRulesCollection()
/**
* @var $collection Ebizmarts_MailChimp_Model_Resource_Ecommercesyncdata_PromoRules_Collection
*/
$collection = Mage::getResourceModel('mailchimp/ecommercesyncdata_promorules_collection');
$collection = Mage::getResourceModel('mailchimp/ecommercesyncdata_promoRules_collection');

return $collection;
}
Expand Down
Loading

0 comments on commit 270db22

Please sign in to comment.