Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate code for marketing-php APIs variables #363

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

webkod3r
Copy link
Contributor

Description

Generates the code for Marketing API that is breaking support for PHP 8.

Known Issues

PHP 8 does not allow the property creation on-the-fly

See https://php.watch/versions/8.2/dynamic-properties-deprecated for why this is necessary.

@cla-bot cla-bot bot added the cla-signed label Jul 22, 2024
@webkod3r
Copy link
Contributor Author

This PR fixes #356

@webkod3r webkod3r merged commit 2c1bd86 into mailchimp:main Jul 22, 2024
19 checks passed
@webkod3r webkod3r deleted the marketing-php8-support branch July 22, 2024 18:31
@RoyvanEmpel
Copy link

Why hasn't the https://github.com/mailchimp/mailchimp-transactional-php been updated with this fix yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants