Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing ruby test and php SDK json form #340

Merged
merged 1 commit into from
Dec 4, 2023
Merged

fixing ruby test and php SDK json form #340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/create-release-transactional.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,7 @@ jobs:
unzip zip/mailchimp-transactional-ruby.zip -d swagger-out/transactional-ruby

- name: Set up Ruby 2.6
uses: actions/setup-ruby@v1
uses: ruby/setup-ruby@v1
with:
ruby-version: '2.6'

Expand Down
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

## Transactional

### 1.0.53
* Fixed broken ruby SDK test, updated PHP SDK to send form data via JSON

### 1.0.52
* Added the `is_broken_template` response to the /template endpoints that include it

Expand Down
2 changes: 1 addition & 1 deletion spec/transactional.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@
},
"swagger": "2.0",
"info": {
"version": "1.0.52",
"version": "1.0.53",
"title": "Mailchimp Transactional API",
"contact": {
"name": "API Support",
Expand Down
2 changes: 1 addition & 1 deletion swagger-config/transactional/php/templates/Configuration.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ class Configuration

// prepare request params
$postUrl = $this->getHost() . $path;
$options['form_params'] = $body;
$options['json'] = $body;

// set output format
$defaultOutputFormat = $this->getDefaultOutputFormat();
Expand Down