Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing params to searchTags marketing spec #309

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

danrwalker
Copy link

Description

The result set returned by tagSearch in the Marketing API was limited to 10 results by default. There are currently no parameters to allow the user to change the limit or set the offset when returning the data.

Added two new parameters 'count' and 'offset' to the tagSearch method, the result set can now be paginated and return the required amount of results.

I have generated the client libraries, running a test confirmed that the new paramters are working as expected.

Known Issues

No know issues with the new parameters.

…, the result set was limited by default to 10 results with no way to request more.
@cla-bot
Copy link

cla-bot bot commented Aug 12, 2022

Contributor License Agreement Instructions
Thanks for your pull request. Before we can review your work, you’ll need to sign a Contributor License Agreement (CLA).

Please download the appropriate CLA below. Once downloaded, please read, sign, and send back to us at [email protected]. Please note, this account is not monitored so please visit https://mailchimp.com/contact/ if you need support.

Individual CLA: Mailchimp Individual CLA
Corporate CLA: Mailchimp Corporate CLA

Once you’ve emailed us the signed CLA, please reply here (e.g. CLA signed and sent!) and we’ll verify it.

What to do if you already signed the CLA
Individual signers
• If you’ve previously sent us a signed CLA, please reply here letting us know and we’ll verify. If we are unable to verify, It’s possible we don’t have your GitHub username or you’re using a different email address on your Git commit. Check that the CLA you previously submitted was sent to us using the email address associated with your GitHub username and verify that your email is set on your Git commits.
Corporate signers
• Your company has a Point of Contact (POC) who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you’ve previously sent us an updated CLA, please reply here letting us know and we’ll verify.
• The email used to register you as an authorized contributor must be the email used for the Git commit.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

@danrwalker
Copy link
Author

CLA signed and sent!

1 similar comment
@danrwalker
Copy link
Author

CLA signed and sent!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant