Moved syncMemberEvents method over to core.js

mailchimp · Jan 24, 2024 · 926897b · 926897b
1 parent 991a005
commit 926897b
Show file tree

Hide file tree

Showing 2 changed files with 69 additions and 69 deletions.
diff --git a/functions/core.js b/functions/core.js
@@ -317,11 +317,79 @@ async function syncMemberTags(newDoc, prevDoc) {
   }
 }
 
+/**
+ * Sync merge fields between Firestore and Mailchimp according to changes
+ * between the provided documents.
+ * @param {FirebaseFirestore.DocumentData | undefined} newDoc
+ * @param {FirebaseFirestore.DocumentData | undefined} prevDoc
+ */
+async function syncMemberEvents(newDoc, prevDoc) {
+  // Get the configuration settings for mailchimp custom events as is defined in extension.yml
+  const eventsConfig = config.mailchimpMemberEvents;
+
+  // Validate proper configuration settings were provided
+  if (!mailchimp) {
+    logs.mailchimpNotInitialized();
+    return;
+  }
+  if (!eventsConfig.memberEvents) {
+    logger.log(`A property named 'memberEvents' is required`);
+    return;
+  }
+  if (!Array.isArray(eventsConfig.memberEvents)) {
+    logger.log(`'memberEvents' property must be an array`);
+    return;
+  }
+
+  // Retrieves subscriber tags before/after write event
+  const getMemberEventsFromSnapshot = (snapshot) =>
+    eventsConfig.memberEvents.reduce((acc, memberEventConfiguration) => {
+      const events = resolveValueFromDocumentPath(snapshot, memberEventConfiguration);
+      if (Array.isArray(events) && events && events.length) {
+        return [...acc, ...events];
+      }
+      if (events) {
+        return acc.concat(events);
+      }
+      return acc;
+    }, []);
+
+  // Get all member events prior to write event
+  const prevEvents = prevDoc ? getMemberEventsFromSnapshot(prevDoc) : [];
+  // Get all member events after write event
+  const newEvents = newDoc ? getMemberEventsFromSnapshot(newDoc) : [];
+  // Find the intersection of both collections
+  const memberEvents = newEvents.filter((e) => !prevEvents.includes(e));
+
+  // Compute the mailchimp subscriber email hash
+  const subscriberHash = subscriberHasher(
+    getSubscriberEmail(prevDoc, newDoc, eventsConfig.subscriberEmail),
+  );
+
+  // Invoke mailchimp API with new events
+  if (memberEvents?.length) {
+    const requests = memberEvents.reduce((acc, name) => {
+      acc.push(
+        retry(
+          () =>
+            mailchimp.lists.createListMemberEvent(config.mailchimpAudienceId, subscriberHash, {
+              name,
+            }),
+          errorFilterFor404,
+        ),
+      );
+      return acc;
+    }, []);
+    await Promise.all(requests);
+  }
+}
+
 module.exports = {
   config,
   processConfig,
   syncMemberTags,
   syncMergeFields,
+  syncMemberEvents,
   addUser,
   subscriberHasher,
   retry,

diff --git a/functions/index.js b/functions/index.js
@@ -13,8 +13,7 @@ const {
   subscriberHasher,
   syncMemberTags,
   syncMergeFields,
-  resolveValueFromDocumentPath,
-  getSubscriberEmail,
+  syncMemberEvents,
 } = require("./core");
 const { syncAuth, syncFirestore, enqueueBackfillTask, performBackfill } = require("./backfill");
 const logs = require("./logs");
@@ -138,73 +137,6 @@ exports.mergeFieldsHandler = firestore
     }
   });
 
-/**
- * Sync merge fields between Firestore and Mailchimp according to changes
- * between the provided documents.
- * @param {FirebaseFirestore.DocumentData | undefined} newDoc
- * @param {FirebaseFirestore.DocumentData | undefined} prevDoc
- */
-async function syncMemberEvents(newDoc, prevDoc) {
-  // Get the configuration settings for mailchimp custom events as is defined in extension.yml
-  const eventsConfig = config.mailchimpMemberEvents;
-
-  // Validate proper configuration settings were provided
-  if (!mailchimp) {
-    logs.mailchimpNotInitialized();
-    return;
-  }
-  if (!eventsConfig.memberEvents) {
-    logger.log(`A property named 'memberEvents' is required`);
-    return;
-  }
-  if (!Array.isArray(eventsConfig.memberEvents)) {
-    logger.log(`'memberEvents' property must be an array`);
-    return;
-  }
-
-  // Retrieves subscriber tags before/after write event
-  const getMemberEventsFromSnapshot = (snapshot) =>
-    eventsConfig.memberEvents.reduce((acc, memberEventConfiguration) => {
-      const events = resolveValueFromDocumentPath(snapshot, memberEventConfiguration);
-      if (Array.isArray(events) && events && events.length) {
-        return [...acc, ...events];
-      }
-      if (events) {
-        return acc.concat(events);
-      }
-      return acc;
-    }, []);
-
-  // Get all member events prior to write event
-  const prevEvents = prevDoc ? getMemberEventsFromSnapshot(prevDoc) : [];
-  // Get all member events after write event
-  const newEvents = newDoc ? getMemberEventsFromSnapshot(newDoc) : [];
-  // Find the intersection of both collections
-  const memberEvents = newEvents.filter((e) => !prevEvents.includes(e));
-
-  // Compute the mailchimp subscriber email hash
-  const subscriberHash = subscriberHasher(
-    getSubscriberEmail(prevDoc, newDoc, eventsConfig.subscriberEmail),
-  );
-
-  // Invoke mailchimp API with new events
-  if (memberEvents?.length) {
-    const requests = memberEvents.reduce((acc, name) => {
-      acc.push(
-        retry(
-          () =>
-            mailchimp.lists.createListMemberEvent(config.mailchimpAudienceId, subscriberHash, {
-              name,
-            }),
-          errorFilterFor404,
-        ),
-      );
-      return acc;
-    }, []);
-    await Promise.all(requests);
-  }
-}
-
 exports.memberEventsHandler = firestore
   .document(config.mailchimpMemberEventsWatchPath)
   .onWrite(async (event) => {