-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update of use of USDA cost shares #741
Conversation
p38_capital_cost_shares_iso(t,iso)$(m_year(t)>=2010) = f38_reg_parameters("slope") * log10(im_gdp_pc_ppp_iso(t,iso)) + f38_reg_parameters("intercept") + p38_share_calibration(iso); | ||
|
||
* aggregate factor cost shares | ||
pm_factor_cost_shares(t,i,"capital") = (1/sum(i_to_iso(i,iso), f38_hist_factor_costs("y2010",iso))) * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why does pm_factor_cost_shares have a time dimenson, if only "y2010" is used? why is only 2010 used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the aggregation is done for all years, but we use fixed 2010 values for the aggregation weight (p38_capital_cost_shares_iso in the next line also has the time dimension)
🐦 Description of this PR 🐦
This PR updates data related to the USDA cost shares (affecting input data on factor costs, factor requirements, labor-capital share within factor costs, hourly labor costs). The capital share regression is now calibrated and used for projections on country level, which are then aggregated to regional level (instead of applying the regression directly on regional level). As the cost shares are the same in different modules (factor costs, livestock, employment, maccs), we now use a global parameter instead of module-specific parameters.
🔧 Checklist for PR creator 🔧
Label pull request from the label list.
Self-review own code
magpie4
R library has been updated accordingly and backwards compatible where necessary.scenario_config.csv
has been updated accordingly (important ifdefault.cfg
has been updated)Document changes
CHANGELOG.md
goxygen::goxygen()
and verify the modified code is properly documentedPerform test runs
Rscript start.R --> "compilation check"
Rscript start.R --> "test runs"
Rscript start.R --> "test runs"
Comparing runs using the sticky factor cost and livestock realizations with regional factor requirements (as this is the set up for which employment is calibrated)
📉 Performance changes 📈
🚨 Checklist for reviewer 🚨
CHANGELOG
is updated correctly