Peatland considered during disaggregation

[pvjeetze]

🐦 Description of this PR 🐦

• This PR makes sure that peatlands are considered during the disaggregation of land pools.
• The PR only includes minor changes to extra/disaggregation.R
• The main changes were made in the function luscale::interpolateAvlCroplandWeighted(), which is the main disaggregation function for MAgPIE land pools: pik-piam/luscale@51d2eba

🔧 Checklist for PR creator 🔧

• Label pull request from the label list.

  • Low risk: Simple bugfixes (missing files, updated documentation, typos) or changes in start or output scripts
  • Medium risk: Uncritical changes in the model core (e.g. moderate modifications in non-default realizations)
  • High risk: Critical changes in model core or default settings (e.g. changing a model default or adjusting a core mechanic in the model)

• Self-review own code

  • No hard coded numbers and cluster/country/region names.
  • The new code doesn't contain declared but unused parameters or variables.
  • magpie4 R library has been updated accordingly and backwards compatible where necessary.
  • scenario_config.csv has been updated accordingly (important if default.cfg has been updated)

• Document changes

  • Add changes to CHANGELOG.md
  • Where relevant, put In-code documentation comments
  • Properly address updates in interfaces in the module documentations
  • run goxygen::goxygen() and verify the modified code is properly documented

• Perform test runs

  • Low risk:
    • Run a compilation check via Rscript start.R --> "compilation check"
  • Medium risk:
    • Run test runs via Rscript start.R --> "test runs"
    • Check logs for errors/warnings
  • High risk:
    • Run test runs via Rscript start.R --> "test runs"
    • Check logs for errors/warnings
    • Default run from the PR target branch for comparison
    • Provide relevant comparison plots (land-use, emissions, food prices, land-use intensity,...)

📉 Performance changes 📈

• Current develop branch default : ** mins
• This PR's default : ** mins

🚨 Checklist for reviewer 🚨

• PR is labeled correctly
• Code changes look reasonable
  • No hard coded numbers and cluster/country/region names.
  • No unnecessary increase in module interfaces
  • model behavior/performance is satisfactory.
• Changes are properly documented
  • CHANGELOG is updated correctly
  • Updates in interfaces have been properly addressed in the module documentations
  • In-code documentation looks appropriate
• content review done (at least 1)
• RSE review done (at least 1)

[pascal-sauer]

In which case do we get Inf here? When dimsums land_hr is 0 then peat_hr should also be zero, no?

[pvjeetze]

@flohump can maybe answer this better, since I only moved the code block further up. But I guess In some instances there might be cases where there is reported peatland, but LUH does not report land area. In R 1/0 = Inf

[flohump]

Looks good. Many thanks for these improvements.

[flohump]

I found a bug in extra/disaggregation.R and fixed it
@pvjeetze please check
I also made a bugfix in luscale::interpolateAvlCroplandWeighted()