Skip to content

Commit

Permalink
Update cran-comments
Browse files Browse the repository at this point in the history
  • Loading branch information
magnusdv committed Dec 2, 2019
1 parent 93e81d5 commit 37471e8
Showing 1 changed file with 5 additions and 36 deletions.
41 changes: 5 additions & 36 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,36 +1,6 @@
## Resubmission
This is a resubmission. In this version I have:
## Release summary

* Removed "Tools for" from the package title

* Reset the par() settings in the example where this was changed.

* Added `on.exit(par(opar))` in functions where par() settings are changed

In one of these functions, `plot.ped()` it is sometimes useful to keep the graphical parameters in order to enable further modifications. To achieve this I have added an argument `keep.par` (default = FALSE) to the function, and inside the function I use
```
if(!keep.par)
on.exit(par(opar))
```

## Resubmission
This is a resubmission. In this version I have:

As requested:
* Removed "in R" from the package title.

* Modified the code of `getAlleles()`, so that it always returns
a character matrix, as documented (instead of NULL in some cases).

And also:
* Added a URL entry to the DESCRIPTION file.

* Made some very minor style changes.

* Changed the name of a single variable throughout (`markerdata` --> `MARKERS`).

I have rerun all checks to ensure no errors/warnings/notes were introduced.

This is an minor release

## Test environments
* local Windows 10 install, R 3.6.1
Expand All @@ -39,9 +9,8 @@ I have rerun all checks to ensure no errors/warnings/notes were introduced.

## R CMD check results

0 errors | 0 warnings | 1 note

## Comments
0 errors | 0 warnings | 0 notes

NOTE: This is a new release.
## revdepcheck results

2 reverse dependencies, 0 problems detected

0 comments on commit 37471e8

Please sign in to comment.