This repository has been archived by the owner on Mar 25, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 17
feat(fbcnms-ui): Add Organization detail #152
Open
HannaFar
wants to merge
2
commits into
magma:main
Choose a base branch
from
HannaFar:OrganizationOnboardingDetail
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Jan 14, 2022
HannaFar
force-pushed
the
OrganizationOnboardingDetail
branch
from
January 14, 2022 13:23
30b7116
to
0e50019
Compare
andreilee
suggested changes
Jan 14, 2022
HannaFar
force-pushed
the
OrganizationOnboardingDetail
branch
2 times, most recently
from
January 19, 2022 13:54
6634821
to
3ef04f4
Compare
HannaFar
force-pushed
the
OrganizationOnboardingDetail
branch
4 times, most recently
from
February 14, 2022 16:50
0ab5f10
to
9dbc9e2
Compare
HannaFar
force-pushed
the
OrganizationOnboardingDetail
branch
2 times, most recently
from
February 18, 2022 10:11
a7fc1b5
to
e18da6b
Compare
HannaFar
changed the title
[WIP] feat(fbcnms-ui): Add Organization detail
feat(fbcnms-ui): Add Organization detail
Feb 23, 2022
HannaFar
force-pushed
the
OrganizationOnboardingDetail
branch
from
February 23, 2022 14:48
e18da6b
to
56ea666
Compare
andreilee
approved these changes
Mar 8, 2022
HannaFar
force-pushed
the
OrganizationOnboardingDetail
branch
from
March 8, 2022 13:18
56ea666
to
eed2aae
Compare
andreilee
suggested changes
Mar 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Change the tab color from light grey to dark grey
- The users table in the Organization Details should have an option for "Edit" , not "View"
HannaFar
force-pushed
the
OrganizationOnboardingDetail
branch
3 times, most recently
from
March 14, 2022 15:09
ac4379b
to
02b76a7
Compare
Signed-off-by: HannaFar <[email protected]>
andreilee
suggested changes
Mar 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to edit this for the 'master'->'host' changes
Signed-off-by: HannaFar <[email protected]>
HannaFar
force-pushed
the
OrganizationOnboardingDetail
branch
from
March 24, 2022 14:32
02b76a7
to
01ce1a1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Organization detail page
Add Edit Organization
Add optional advanced fields
Organization detail:
Organization without advanced fields
Organization with advanced fields
Add User
Edit User