Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tokenizer to core extensions list #360

Closed
wants to merge 1 commit into from

Conversation

xepozz
Copy link
Contributor

@xepozz xepozz commented Nov 1, 2022

Add ext-tokenizer to core extensions #358

@Ocramius
Copy link
Collaborator

As per #358 (comment), this shouldn't be done, IMO

While the JSON extension can no longer be disabled as per https://github.com/php/php-src/blob/f4f03ae115d00af8b177f6a9a97ec63a72307592/UPGRADING#L991, the tokenizer can be.

Closing as "won't fix" - can be re-evaluated once --disable-tokenizer is gone from php-src.

@Ocramius Ocramius closed this Nov 11, 2022
@Ocramius Ocramius self-assigned this Nov 11, 2022
@Ocramius Ocramius added enhancement wontfix dependencies Pull requests that update a dependency file labels Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement wontfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants