Code review support #110
Merged
Code review support #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarsius
requested changes
Apr 15, 2020
| @@ -174,12 +175,14 @@ data as the only argument." | |||
| :username username | |||
| :auth auth | |||
| :host host | |||
| :headers headers | |||
| :forge forge | |||
There was a problem hiding this comment.
I feel that host and forge should remain to each other, here and elsewhere, because only taken together the fully specify the other side we are communicating with.
There was a problem hiding this comment.
yes sure I'll do the change in the next version.
JulienMasson
force-pushed
the
code-review-support
branch
from
f8cb0a6 to
a044be6
Compare
JulienMasson
force-pushed
the
code-review-support
branch
from
a044be6 to
1d0ae30
Compare
|
In the latest version of this PR, I added the function In that way, we don't hit GitHub GraphQL API limitations: |
JulienMasson
force-pushed
the
code-review-support
branch
from
c604f8b to
6a93d7a
Compare
tarsius
force-pushed
the
code-review-support
branch
from
6a93d7a to
6b6b9d4
Compare
Signed-off-by: Julien Masson <[email protected]>
PullRequestReviewThread object is a threaded list of review comments for a given pull request. headRefOid and baseRefOid are the respective head and base SHA reference for a given pull request. The GitHub GraphQL API has limitations, Individual calls cannot request more than 500,000 total nodes. Thus in order to fetch reviewThreads from a pull-request, we need to fetch these data in a dedicated function: `ghub-fetch-review-threads'. Otherwise we will have this kind of error message: "By the time this query traverses to the comments connection, it is requesting up to 1,000,000 possible nodes which exceeds the maximum limit of 500,000." Source: https://docs.github.com/en/free-pro-team@latest/graphql/overview/resource-limitations https://docs.github.com/en/free-pro-team@latest/graphql/reference/objects#pullrequestreviewthread Signed-off-by: Julien Masson <[email protected]>
tarsius
force-pushed
the
code-review-support
branch
from
6b6b9d4 to
f26c1f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow to fetch more informations on pull-request.
They are needed to have the code-review support for Github:
magit/forge#266
Max Node Limit Exceeded
Indeed when I add the
reviewThreadsobject inghub-fetch-repository, I received this error from the server:As workaround I added
ghub-fetch-repository-review-threadswhich is minimal in order to fetch onlypullRequestsand avoid the error above.If you don't mind, I would like your opinion on that.
For Gitlab we don't have this issue since we are sending multiple requests to grab all the informations needed (btw much slower).
However for Github, for the moment I don't know how to handle this case ...