-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
split into frontend and backend to support multiple sigma versions in parallel #53
Conversation
f869e8d
to
7ce0575
Compare
@M3NIX apologies for not getting to this sooner, I tried doing a local build using docker of the branch and ran into a issue:
Looks related to some of the deps required by pysigma specifically |
It seems to be a bug/issue with the latest pyparsing version which was now pulled in automatically during build time. I will ping you if a new working version is available :) |
@josehelps docker build -t m3nix/sigconverter .
docker run -d -p 8000:8000 m3nix/sigconverter |
Worked flawlessly thank you for the update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request tries to solve the current problem of sigconverter that different sigma backends have different dependency versions to
pySigma
/sigma-cli
. Therefore we have to chose one version at the moment and can not include all backends or easily upgrade to newer sigma versions.To solve this, this PR includes the following changes:
backend/setup-sigma-versions.sh
) is included which will automatically fetch the latest 10 versions ofsigma-cli
and creates an isolated python environment for them. in that environment all plugins with their latest compatible version will be installed. non compatible versions will be skipped during the installation.sigma-cli
versionsIf we would schedule to weekly (or daily) build the docker container which runs the setup script we would automatically have the latest versions of
sigma-cli
and the plugins installed without any further manual need to add new plugins.Happy to get feedback from you @josehelps @nasbench @MHaggis :)