Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add hide editor param #23

Merged
merged 2 commits into from
Nov 13, 2023
Merged

feat: add hide editor param #23

merged 2 commits into from
Nov 13, 2023

Conversation

nasbench
Copy link
Member

This PR adds the following:

  • And API endpoint to get the list of pipelines (this is a start and will add more functions in the near future to make it integrates with other products)
  • Adds a hideEditor params that will be used with the Sigma vscode extension. Basically it'll allow people to modify and convert their stuff from vscode and only show the results. (see ss below for a somewhat of an example)

image

@nasbench nasbench requested review from M3NIX and josehelps November 13, 2023 17:10
M3NIX
M3NIX approved these changes Nov 13, 2023
View reviewed changes
Copy link
Collaborator

@M3NIX M3NIX left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works and LGTM

hideEditor=1
image

/getpipelines Endpoint:
image

@nasbench nasbench merged commit d96fa3d into magicsword-io:main Nov 13, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M3NIX M3NIX M3NIX approved these changes

@josehelps josehelps Awaiting requested review from josehelps

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nasbench @M3NIX