Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added pipeline parameter to the url sharing feature #21

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

M3NIX
Copy link
Collaborator

@M3NIX M3NIX commented Nov 10, 2023

The last PR #16 was missing the pipeline parameter in the URL. This PR now adds the parameter. To define multiple pipelines in the URL you can simply seperate them with a semicolon ;. This is done automatically when pressing the share button.

Examples:
http://localhost:8000/#backend=splunk&format=data_model&pipeline=splunk_cim
http://localhost:8000/#backend=ibm-qradar-aql&format=default&pipeline=qradar-aql-fields;qradar-aql-payload

@M3NIX M3NIX requested a review from nasbench November 10, 2023 17:03
Copy link
Member

@nasbench nasbench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nasbench nasbench merged commit 2eb2dfc into main Nov 10, 2023
1 check passed
@M3NIX M3NIX deleted the feature/url-pipeline-parameter branch November 11, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants