Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redo of frontend with tailwind ui css framework #12

Merged
merged 3 commits into from
Oct 17, 2023
Merged

redo of frontend with tailwind ui css framework #12

merged 3 commits into from
Oct 17, 2023

Conversation

M3NIX
Copy link
Collaborator

@M3NIX M3NIX commented Oct 16, 2023

following aspects of the page changed:

  • tailwind ui instead of semantic ui css framework
  • color scheme inspired by sigmahq.io
  • better responsiveness for different display resolutions
  • using tom-select.js for select dropdowns
  • added header (rule.yml, query) above the code areas
  • copy button moved to the output code area
  • cleanup of javascript functions
  • moved onchange / onclick handler away from html to javascript

mockup (frontend only, no rule conversion) can be viewed in this codepen sandbox

@M3NIX M3NIX requested a review from nasbench October 16, 2023 20:33
@nasbench nasbench self-assigned this Oct 17, 2023
@josehelps josehelps self-requested a review October 17, 2023 14:12
@josehelps
Copy link
Contributor

😄
image

josehelps
josehelps approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@josehelps josehelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks beautiful, and ran smoothly lgmt

@josehelps josehelps merged commit d30feca into main Oct 17, 2023
1 check passed
@M3NIX M3NIX deleted the frontend/tailwind-ui branch October 23, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josehelps josehelps josehelps approved these changes

@nasbench nasbench Awaiting requested review from nasbench

Assignees

@nasbench nasbench

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@M3NIX @josehelps @nasbench