-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add changeset tooling #39
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stigi
commented
Oct 2, 2024
smeijer
approved these changes
Oct 7, 2024
This will update all other occurences of the version number
stigi
force-pushed
the
ullrich/add-changesets
branch
from
October 7, 2024 10:50
19c18cc
to
153640a
Compare
@smeijer heads up that I did a small, but significant, change in 153640a The workflow now invokes |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
This PR adds tooling around managing change sets, by employing https://github.com/changesets/changesets
The source of truth for the project version now relies in
package.json
and is propagated via a script to all other places (Readme.md
, swift sources).I also imported the last changeset from the current version 2.0.0 as a baseline and added pending changesets for work that was done in #38 and that will go out in a major release.
A few things went into this to make it work:
@changeset
dependenciesyarn changeset
that also calls theupdate-version.ts
script to update the version accross the repo.package.json
Test Plan
Check out this branch, create an example changeset via
yarn changeset
oryarn changeset add
. Bump the version viayarn changeset version
. The version should be updated inpackage.json
,Readme.md
as wellMagicBellClient.swift
.Also take a look at #42 which was created by the workflow that's part of this PR.
Type of Change