Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating to modern maven publish plugin #30

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Conversation

stigi
Copy link
Member

@stigi stigi commented Oct 11, 2024

Change description

We've been using a pretty old way of publishing to maven central and I'd like to migrate to a newer plugin:
https://github.com/vanniktech/gradle-maven-publish-plugin

The also mention that they are the spiritual successor to the approach we're currnetly using (aka Chris Banes initial implementation)

Benefits:

  • Simpler setup. Less code to maintain
  • Support for new Central Portal. This will make it easier to migrate our distrubution from the now legacy OSSHR system we're using right now. (migration docs)
  • Full support for passing secrets via env vars

Test Plan

Tested locally, and build build signs and pulishes locally as expected:

$ ORG_GRADLE_PROJECT_signingInMemoryKey="...." \
  ORG_GRADLE_PROJECT_signingInMemoryKeyId="...." \
  ORG_GRADLE_PROJECT_signingInMemoryKeyPassword="..." \
  ./gradlew sdk:publishToMavenLocal

I compared the pom-default.xml files generated with the previous version and saw no difference.

Type of Change

  • Bug fix
  • Feature
  • Enhancement

Guidelines

  • A changeset is included, or the change is not noteworthy enough to warrant one

@stigi stigi force-pushed the ullrich/migrate-maven-publish branch from 9fb6516 to 6236779 Compare October 11, 2024 23:08
@stigi stigi force-pushed the ullrich/migrate-maven-publish branch from 6236779 to 0c71508 Compare October 11, 2024 23:10
@stigi stigi marked this pull request as ready for review October 11, 2024 23:32
@stigi stigi merged commit 358b773 into main Oct 11, 2024
2 checks passed
@stigi stigi deleted the ullrich/migrate-maven-publish branch October 11, 2024 23:32
@stigi stigi restored the ullrich/migrate-maven-publish branch October 11, 2024 23:32
@stigi stigi deleted the ullrich/migrate-maven-publish branch October 11, 2024 23:33
stigi added a commit that referenced this pull request Oct 12, 2024
stigi added a commit that referenced this pull request Oct 14, 2024
@stigi stigi self-assigned this Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant