Added n98-magerun2 command to CLI containers #346
+60
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the N98-Magerun2 binary to the CLI containers to be used during development. Magerun can be ran in a similar fashion as the other commands.
Fixed Issues (if relevant)
Manual testing scenarios
E.g. in the
images/php/7.4-cli
folder:docker build --tag magento/magento-cloud-docker-php:7.4-cli-1.3.2-magerun .
docker run --rm magento/magento-cloud-docker-php:7.4-cli-1.3.2-magerun magerun2 list
It should output the list of possible commands. I have noticed that for me it was required to force ANSI output with the
--ansi
flag; is this only on my machine, or reproducible across the board? If the latter we should consider updating themagerun2
command to always pass the--ansi
flag.I have tested the
7.2-cli
,7.3-cli
and7.4-cli
containers. I might have missed some incompatibility somewhere.Release notes
Associated documentation updates
If this change will be accepted I will do the digging in the DevDocs to add references to this functionality to it.
Contribution checklist