Add EncodeReturn, EncodeArgument and EncodeArguments
#497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
added
enhancement
madsmtm
force-pushed
the
refactor-encodings
branch
8 times, most recently
from
856cdcc
to
d5f9c31
Compare
And make the two conversion traits ConvertReturn and ConvertArgument in a sense "more" private
madsmtm
force-pushed
the
refactor-encodings
branch
from
d5f9c31
to
e03b060
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do a general refactoring around our unstable encoding traits, and expose some of them (since they were present in several public interfaces, including in
block2), while we make the two conversion traitsConvertReturnandConvertArgumentin a sense "more" private.This is working towards the design outlined in #457 (comment).
Another breaking change not noted in the changelog:
encode::__unstable::EncodeReturnwas removed, which would breakblock2if upgraded in a non-breaking release.