Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metal example #489

Merged
merged 5 commits into from
Aug 28, 2023
Merged

Metal example #489

merged 5 commits into from
Aug 28, 2023

Conversation

silvanshade
Copy link
Contributor

This PR adds the Metal API example corresponding to the discussion at #483.

@PicoLeaf I merged your commits and did some final refactoring. Thanks for adding the animation part in there and creating the other PR.

@silvanshade silvanshade mentioned this pull request Aug 27, 2023
Closed
madsmtm
madsmtm reviewed Aug 28, 2023
View reviewed changes
crates/icrate/Cargo.toml Show resolved Hide resolved
crates/icrate/examples/metal.rs Show resolved Hide resolved
crates/icrate/examples/metal.rs Outdated Show resolved Hide resolved
crates/icrate/examples/metal.rs Show resolved Hide resolved
crates/icrate/examples/metal.rs Outdated Show resolved Hide resolved
@silvanshade silvanshade force-pushed the metal-example branch 2 times, most recently from ac1b20c to 79c4109 Compare August 28, 2023 12:00
@silvanshade
Copy link
Contributor Author

Okay, I think I've addressed all the comments.

madsmtm
madsmtm reviewed Aug 28, 2023
View reviewed changes
Copy link
Owner

@madsmtm madsmtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, just one more, then I think we're good

crates/icrate/examples/metal.rs Outdated Show resolved Hide resolved
@silvanshade silvanshade force-pushed the metal-example branch 2 times, most recently from bfbac2f to 5c1f44b Compare August 28, 2023 12:21
@madsmtm madsmtm added documentation Improvements or additions to documentation A-framework Affects the framework crates and the translator for them labels Aug 28, 2023
madsmtm
madsmtm approved these changes Aug 28, 2023
View reviewed changes
Copy link
Owner

@madsmtm madsmtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, will merge once CI passes

@madsmtm madsmtm merged commit e962fc7 into madsmtm:master Aug 28, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madsmtm madsmtm madsmtm approved these changes

Assignees
No one assigned
Labels
A-framework Affects the framework crates and the translator for them documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@silvanshade @madsmtm @PicoLeaf